From 9bccbc5a1e739b65f37f87a77c1ca0e943e6e856 Mon Sep 17 00:00:00 2001 From: Collecting Date: Wed, 14 Jan 2026 04:03:51 +0000 Subject: [PATCH] fix(rev): Mistakenly placed 12 instead of 15 Signed-off-by: Collecting --- .../renderer/command/command_generator.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/audio_core/renderer/command/command_generator.cpp b/src/audio_core/renderer/command/command_generator.cpp index 567e7a580..786472c37 100644 --- a/src/audio_core/renderer/command/command_generator.cpp +++ b/src/audio_core/renderer/command/command_generator.cpp @@ -363,14 +363,14 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset EffectInfoBase& effect_info, const s32 node_id) { u8* raw_params = effect_info.GetParameter(); + + // REV15 introduced the new native float-based Biquad Filter structure (Version 2). + // REV14 and older (including Rev 12 splitter updates) still use the Int16 version. + const bool is_rev15 = render_context.behavior->GetProcessRevision() >= 15; - // Revision 12 introduced the new float-based Biquad Filter - // Revision 11 and older use the original Int16 version - const bool is_rev12 = render_context.behavior->GetProcessRevision() >= 12; - - if (is_rev12) { + if (is_rev15) { auto& parameter = *reinterpret_cast(raw_params); - + s8 channels = parameter.channel_count; if (channels > 6 || channels < 0) channels = 0; @@ -385,10 +385,10 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel); } } - parameter.state = EffectInfoBase::ParameterState::Updated; // Offset 0x25 + parameter.state = EffectInfoBase::ParameterState::Updated; } else { auto& parameter = *reinterpret_cast(raw_params); - + s8 channels = parameter.channel_count; if (channels > 6 || channels < 0) channels = 0; @@ -418,7 +418,7 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel); } } - parameter.state = EffectInfoBase::ParameterState::Updated; // Offset 0x17 + parameter.state = EffectInfoBase::ParameterState::Updated; } }