Compare commits

..

1 Commits

Author SHA1 Message Date
Jean-Baptiste
908ba925ae [android] Simplify toolbar styles and themes
Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>
2025-12-28 19:26:27 +01:00
57 changed files with 180 additions and 688 deletions

View File

@@ -351,7 +351,6 @@ dependencies {
implementation libs.androidx.recyclerview implementation libs.androidx.recyclerview
implementation libs.androidx.work.runtime implementation libs.androidx.work.runtime
implementation libs.androidx.lifecycle.process implementation libs.androidx.lifecycle.process
implementation libs.androidx.documentfile
implementation libs.android.material implementation libs.android.material
// Fix for app/organicmaps/util/FileUploadWorker.java:14: error: cannot access ListenableFuture // Fix for app/organicmaps/util/FileUploadWorker.java:14: error: cannot access ListenableFuture
// https://github.com/organicmaps/organicmaps/issues/6106 // https://github.com/organicmaps/organicmaps/issues/6106

View File

@@ -9,8 +9,7 @@ import static app.organicmaps.leftbutton.LeftButtonsHolder.BUTTON_HELP_CODE;
import static app.organicmaps.leftbutton.LeftButtonsHolder.BUTTON_RECORD_TRACK_CODE; import static app.organicmaps.leftbutton.LeftButtonsHolder.BUTTON_RECORD_TRACK_CODE;
import static app.organicmaps.leftbutton.LeftButtonsHolder.BUTTON_SETTINGS_CODE; import static app.organicmaps.leftbutton.LeftButtonsHolder.BUTTON_SETTINGS_CODE;
import static app.organicmaps.sdk.location.LocationState.FOLLOW; import static app.organicmaps.sdk.location.LocationState.FOLLOW;
import static app.organicmaps.sdk.location.LocationState.FOLLOW_AND_ROTATE_COMPASS; import static app.organicmaps.sdk.location.LocationState.FOLLOW_AND_ROTATE;
import static app.organicmaps.sdk.location.LocationState.FOLLOW_AND_ROTATE_ROUTE;
import static app.organicmaps.sdk.location.LocationState.LOCATION_TAG; import static app.organicmaps.sdk.location.LocationState.LOCATION_TAG;
import static app.organicmaps.sdk.util.PowerManagment.POWER_MANAGEMENT_TAG; import static app.organicmaps.sdk.util.PowerManagment.POWER_MANAGEMENT_TAG;
import static app.organicmaps.sdk.util.Utils.dimen; import static app.organicmaps.sdk.util.Utils.dimen;
@@ -1901,8 +1900,7 @@ public class MwmActivity extends BaseMwmFragmentActivity
locationHelper.restartWithNewMode(); locationHelper.restartWithNewMode();
if ((newMode == FOLLOW || newMode == FOLLOW_AND_ROTATE_ROUTE || newMode == FOLLOW_AND_ROTATE_COMPASS) if ((newMode == FOLLOW || newMode == FOLLOW_AND_ROTATE) && !LocationUtils.checkFineLocationPermission(this))
&& !LocationUtils.checkFineLocationPermission(this))
{ {
// Try to optimistically request FINE permission for FOLLOW and FOLLOW_AND_ROTATE modes. // Try to optimistically request FINE permission for FOLLOW and FOLLOW_AND_ROTATE modes.
Logger.i(LOCATION_TAG, "Requesting ACCESS_FINE_LOCATION permission for " + LocationState.nameOf(newMode)); Logger.i(LOCATION_TAG, "Requesting ACCESS_FINE_LOCATION permission for " + LocationState.nameOf(newMode));

View File

@@ -183,16 +183,11 @@ public final class UiHelpers
drawableRes = R.drawable.ic_follow; drawableRes = R.drawable.ic_follow;
tintColor = Colors.LOCATION_TINT; tintColor = Colors.LOCATION_TINT;
} }
case LocationState.FOLLOW_AND_ROTATE_COMPASS -> case LocationState.FOLLOW_AND_ROTATE ->
{ {
drawableRes = R.drawable.ic_follow_and_rotate; drawableRes = R.drawable.ic_follow_and_rotate;
tintColor = Colors.LOCATION_TINT; tintColor = Colors.LOCATION_TINT;
} }
case LocationState.FOLLOW_AND_ROTATE_ROUTE ->
{
drawableRes = R.drawable.ic_follow_route;
tintColor = Colors.LOCATION_TINT;
}
default -> throw new IllegalArgumentException("Invalid button mode: " + locationMode); default -> throw new IllegalArgumentException("Invalid button mode: " + locationMode);
} }

View File

@@ -98,11 +98,6 @@ public class NavigationController implements TrafficManager.TrafficCallback, Nav
mSpeedLimit = topFrame.findViewById(R.id.nav_speed_limit); mSpeedLimit = topFrame.findViewById(R.id.nav_speed_limit);
mCurrentSpeed = topFrame.findViewById(R.id.nav_current_speed); mCurrentSpeed = topFrame.findViewById(R.id.nav_current_speed);
View mTopbar = topFrame.findViewById(R.id.statutbar);
ViewCompat.setOnApplyWindowInsetsListener(mTopbar,(v, windowInsets) -> {
UiUtils.setViewNavigationTopInsetsMargin(v, windowInsets);
return windowInsets;
});
// Show a blank view below the navbar to hide the menu content // Show a blank view below the navbar to hide the menu content
final View navigationBarBackground = mFrame.findViewById(R.id.nav_bottom_sheet_nav_bar); final View navigationBarBackground = mFrame.findViewById(R.id.nav_bottom_sheet_nav_bar);
final View nextTurnContainer = mFrame.findViewById(R.id.nav_next_turn_container); final View nextTurnContainer = mFrame.findViewById(R.id.nav_next_turn_container);

View File

@@ -196,7 +196,7 @@ public final class UiUtils
public static void showHomeUpButton(MaterialToolbar toolbar) public static void showHomeUpButton(MaterialToolbar toolbar)
{ {
toolbar.setNavigationIcon( toolbar.setNavigationIcon(
ThemeUtils.getResource(toolbar.getContext(), androidx.appcompat.R.attr.homeAsUpIndicator)); UiUtils.getStyledResourceId(toolbar.getContext(), androidx.appcompat.R.attr.homeAsUpIndicator));
} }
// this method returns the total height of the display (in pixels) including notch and other touchable areas // this method returns the total height of the display (in pixels) including notch and other touchable areas
@@ -281,14 +281,6 @@ public final class UiUtils
view.setPadding(systemInsets.left, systemInsets.top, systemInsets.right, view.getPaddingBottom()); view.setPadding(systemInsets.left, systemInsets.top, systemInsets.right, view.getPaddingBottom());
} }
public static void setViewNavigationTopInsetsMargin(View view, WindowInsetsCompat windowInsets)
{
final Insets systemInsets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars());
ViewGroup.MarginLayoutParams lp = (ViewGroup.MarginLayoutParams) view.getLayoutParams();
lp.topMargin = systemInsets.top;
view.setLayoutParams(lp);
}
public static void setupNavigationIcon(@NonNull MaterialToolbar toolbar, @NonNull View.OnClickListener listener) public static void setupNavigationIcon(@NonNull MaterialToolbar toolbar, @NonNull View.OnClickListener listener)
{ {
View customNavigationButton = toolbar.findViewById(R.id.back); View customNavigationButton = toolbar.findViewById(R.id.back);

View File

@@ -49,8 +49,8 @@ public class MyPositionButton
int colorAttr = R.attr.iconTint; int colorAttr = R.attr.iconTint;
@DimenRes @DimenRes
int sizeDimen = R.dimen.map_button_icon_size; int sizeDimen = R.dimen.map_button_icon_size;
if (mode == LocationState.FOLLOW || mode == LocationState.FOLLOW_AND_ROTATE_ROUTE if (mode == LocationState.FOLLOW || mode == LocationState.FOLLOW_AND_ROTATE
|| mode == LocationState.FOLLOW_AND_ROTATE_COMPASS || mode == LocationState.PENDING_POSITION) || mode == LocationState.PENDING_POSITION)
{ {
colorAttr = com.google.android.material.R.attr.colorSecondary; colorAttr = com.google.android.material.R.attr.colorSecondary;
if (mode == LocationState.PENDING_POSITION) if (mode == LocationState.PENDING_POSITION)
@@ -69,8 +69,7 @@ public class MyPositionButton
case LocationState.NOT_FOLLOW_NO_POSITION -> R.drawable.ic_location_off; case LocationState.NOT_FOLLOW_NO_POSITION -> R.drawable.ic_location_off;
case LocationState.NOT_FOLLOW -> R.drawable.ic_location_crosshair; case LocationState.NOT_FOLLOW -> R.drawable.ic_location_crosshair;
case LocationState.FOLLOW -> R.drawable.ic_follow; case LocationState.FOLLOW -> R.drawable.ic_follow;
case LocationState.FOLLOW_AND_ROTATE_COMPASS -> R.drawable.ic_follow_and_rotate; case LocationState.FOLLOW_AND_ROTATE -> R.drawable.ic_follow_and_rotate;
case LocationState.FOLLOW_AND_ROTATE_ROUTE -> R.drawable.ic_follow_route;
default -> throw new IllegalArgumentException("Invalid button mode: " + mode); default -> throw new IllegalArgumentException("Invalid button mode: " + mode);
}; };
image = ResourcesCompat.getDrawable(resources, drawableRes, context.getTheme()); image = ResourcesCompat.getDrawable(resources, drawableRes, context.getTheme());

View File

@@ -1,30 +0,0 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="24"
android:viewportHeight="24">
<path
android:strokeColor="@android:color/white"
android:fillColor="@android:color/white"
android:pathData="M15.15 16.92l-7.04 2.8v0.4l2.63 1.07 0.98 2.67h0.39z"/>
<path
android:strokeColor="@android:color/white"
android:strokeWidth="2"
android:strokeLineJoin="miter"
android:pathData="m 16.25,15.95 c 2.29,-2.29 1.91,-3.87 -4.06,-3.87"/>
<path
android:strokeColor="@android:color/white"
android:strokeWidth="2"
android:strokeLineJoin="miter"
android:pathData="M8.98 7.43c-2.97 2.96-2.72 4.66 3.24 4.66"/>
<path
android:strokeColor="@android:color/white"
android:strokeWidth="2"
android:strokeLineJoin="miter"
android:pathData="M8.89 7.51l8.83-8.79"/>
<path
android:strokeColor="@android:color/white"
android:strokeWidth="2"
android:strokeLineJoin="miter"
android:pathData="M9.2 22.83c-0.64 0.57-2.9 2.5-3.56 3.13"/>
</vector>

View File

@@ -11,12 +11,13 @@
<FrameLayout <FrameLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:id="@+id/statutbar" android:id="@+id/statutbar"
android:layout_height="1dp" android:layout_height="15dp"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />
<com.google.android.material.card.MaterialCardView <com.google.android.material.card.MaterialCardView
android:id="@+id/street_frame" android:id="@+id/street_frame"
android:layout_width="500dp" android:layout_width="500dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_half_plus_eight"
android:layout_marginEnd="@dimen/margin_quarter" android:layout_marginEnd="@dimen/margin_quarter"
app:cardCornerRadius="@dimen/margin_half" app:cardCornerRadius="@dimen/margin_half"
android:elevation="@dimen/nav_elevation" android:elevation="@dimen/nav_elevation"
@@ -51,6 +52,7 @@
app:layout_constraintEnd_toStartOf="@+id/street_frame" app:layout_constraintEnd_toStartOf="@+id/street_frame"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/statutbar" app:layout_constraintTop_toBottomOf="@+id/statutbar"
android:layout_marginTop="@dimen/margin_half_plus_eight"
android:layout_marginStart="@dimen/margin_quarter" android:layout_marginStart="@dimen/margin_quarter"
android:clickable="true" android:clickable="true"
android:elevation="@dimen/nav_elevation"> android:elevation="@dimen/nav_elevation">

View File

@@ -6,14 +6,7 @@
android:orientation="vertical" android:orientation="vertical"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent"> android:layout_height="match_parent">
<com.google.android.material.appbar.MaterialToolbar <include layout="@layout/toolbar_default"/>
android:id="@+id/toolbar"
style="@style/MwmWidget.ToolbarStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="end|center_vertical"
android:theme="@style/MwmWidget.ToolbarTheme">
</com.google.android.material.appbar.MaterialToolbar>
<LinearLayout <LinearLayout
android:layout_marginTop="@dimen/margin_half_double_plus" android:layout_marginTop="@dimen/margin_half_double_plus"
android:orientation="horizontal" android:orientation="horizontal"

View File

@@ -11,12 +11,13 @@
<FrameLayout <FrameLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:id="@+id/statutbar" android:id="@+id/statutbar"
android:layout_height="1dp" android:layout_height="25dp"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />
<com.google.android.material.card.MaterialCardView <com.google.android.material.card.MaterialCardView
android:id="@+id/street_frame" android:id="@+id/street_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_half_plus"
android:layout_marginStart="@dimen/nav_street_left" android:layout_marginStart="@dimen/nav_street_left"
android:layout_marginEnd="@dimen/margin_quarter" android:layout_marginEnd="@dimen/margin_quarter"
app:cardCornerRadius="@dimen/margin_half" app:cardCornerRadius="@dimen/margin_half"
@@ -54,6 +55,7 @@
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/statutbar" app:layout_constraintTop_toBottomOf="@+id/statutbar"
android:layout_marginStart="@dimen/margin_half" android:layout_marginStart="@dimen/margin_half"
android:layout_marginTop="@dimen/margin_half_plus"
android:clickable="true" android:clickable="true"
android:elevation="@dimen/nav_elevation"> android:elevation="@dimen/nav_elevation">
<LinearLayout <LinearLayout

View File

@@ -30,8 +30,7 @@
android:layout_alignParentStart="true" android:layout_alignParentStart="true"
android:background="?selectableItemBackgroundBorderless" android:background="?selectableItemBackgroundBorderless"
app:srcCompat="?homeAsUpIndicator" app:srcCompat="?homeAsUpIndicator"
android:scaleType="center" android:scaleType="center" />
tools:src="@drawable/ic_expand_more" />
<RadioGroup <RadioGroup
android:id="@+id/route_type" android:id="@+id/route_type"

View File

@@ -8,8 +8,7 @@
android:id="@+id/toolbar" android:id="@+id/toolbar"
style="@style/MwmWidget.ToolbarStyle" style="@style/MwmWidget.ToolbarStyle"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content" />
android:theme="@style/MwmWidget.ToolbarTheme.DownButton"/>
<View <View
android:layout_width="match_parent" android:layout_width="match_parent"

View File

@@ -17,7 +17,6 @@
android:background="?selectableItemBackgroundBorderless" android:background="?selectableItemBackgroundBorderless"
app:srcCompat="?homeAsUpIndicator" app:srcCompat="?homeAsUpIndicator"
android:scaleType="center" android:scaleType="center"
tools:src="@drawable/ic_expand_more"
android:contentDescription="@string/back"/> android:contentDescription="@string/back"/>
<com.google.android.material.textfield.TextInputEditText <com.google.android.material.textfield.TextInputEditText

View File

@@ -1,8 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<com.google.android.material.appbar.MaterialToolbar
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/toolbar"
style="@style/MwmWidget.ToolbarStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:theme="@style/MwmWidget.ToolbarTheme.Transparent"/>

View File

@@ -148,11 +148,6 @@
<item name="buttonGravity">center_vertical</item> <item name="buttonGravity">center_vertical</item>
</style> </style>
<style name="MwmWidget.ToolbarStyle.Light">
<item name="android:titleTextAppearance">@style/MwmTextAppearance.Toolbar.Title.Light</item>
<item name="titleTextAppearance">@style/MwmTextAppearance.Toolbar.Title.Light</item>
</style>
<style name="MwmWidget.ToolbarStyle.NoElevation"> <style name="MwmWidget.ToolbarStyle.NoElevation">
<item name="android:elevation">0dp</item> <item name="android:elevation">0dp</item>
</style> </style>
@@ -164,29 +159,6 @@
<item name="iconTint">@color/white_primary</item> <item name="iconTint">@color/white_primary</item>
</style> </style>
<style name="MwmWidget.ToolbarTheme.Light" parent="MwmWidget.ToolbarTheme">
<item name="android:gravity">center_vertical</item>
<item name="colorAccent">@android:color/white</item>
<item name="colorSecondary">#FF32363A</item>
</style>
<style name="MwmWidget.ToolbarTheme.Transparent" parent="ThemeOverlay.Material3.Dark.ActionBar">
<item name="android:gravity">center_vertical</item>
<item name="colorAccent">@android:color/white</item>
<item name="colorSecondary">@android:color/white</item>
<item name="android:windowActionBarOverlay">true</item>
<item name="windowActionBarOverlay">true</item>
</style>
<style
name="MwmWidget.ToolbarTheme.DownButton"
parent="ThemeOverlay.Material3.Dark.ActionBar">
<item name="android:gravity">center_vertical</item>
<item name="colorAccent">@android:color/white</item>
<item name="colorSecondary">@android:color/white</item>
<item name="android:homeAsUpIndicator">@drawable/ic_expand_more</item>
</style>
<style name="MwmWidget.ListView" parent="android:Widget.Material.ListView"> <style name="MwmWidget.ListView" parent="android:Widget.Material.ListView">
<item name="android:fadingEdge">none</item> <item name="android:fadingEdge">none</item>
<item name="android:divider">@color/divider</item> <item name="android:divider">@color/divider</item>

View File

@@ -1,15 +1,15 @@
[versions] [versions]
androidGradlePlugin = "8.13.2" androidGradlePlugin = "8.11.2"
androidxCarApp = "1.7.0" androidxCarApp = "1.7.0"
[libraries] [libraries]
android-tools = { module = "com.android.tools.build:gradle", version.ref = "androidGradlePlugin" } android-tools = { module = "com.android.tools.build:gradle", version.ref = "androidGradlePlugin" }
triplet-play-publisher = { module = "com.github.triplet.gradle:play-publisher", version = "3.13.0" } triplet-play-publisher = { module = "com.github.triplet.gradle:play-publisher", version = "3.12.1" }
huawei-publish = { module = "ru.cian:huawei-publish-gradle-plugin", version = "1.4.2" } huawei-publish = { module = "ru.cian:huawei-publish-gradle-plugin", version = "1.4.2" }
android-tools-desugar = { module = "com.android.tools:desugar_jdk_libs", version = "2.1.5" } android-tools-desugar = { module = "com.android.tools:desugar_jdk_libs", version = "2.1.5" }
microg-services-location = { module = "org.microg.gms:play-services-location", version = "0.3.6.244735" } microg-services-location = { module = "org.microg.gms:play-services-location", version = "0.3.6.244735" }
androidx-core = { module = "androidx.core:core", version = "1.17.0" } androidx-core = { module = "androidx.core:core", version = "1.17.0" }
jetbrains-kotlin-bom = { module = "org.jetbrains.kotlin:kotlin-bom", version = "2.2.21" } jetbrains-kotlin-bom = { module = "org.jetbrains.kotlin:kotlin-bom", version = "2.2.20" }
androidx-annotation = { module = "androidx.annotation:annotation", version = "1.9.1" } androidx-annotation = { module = "androidx.annotation:annotation", version = "1.9.1" }
androidx-appcompat = { module = "androidx.appcompat:appcompat", version = "1.7.1" } androidx-appcompat = { module = "androidx.appcompat:appcompat", version = "1.7.1" }
androidx-car-app = { module = "androidx.car.app:app", version.ref = "androidxCarApp" } androidx-car-app = { module = "androidx.car.app:app", version.ref = "androidxCarApp" }
@@ -21,13 +21,12 @@ androidx-recyclerview = { module = "androidx.recyclerview:recyclerview", version
androidx-work-runtime = { module = "androidx.work:work-runtime", version = "2.10.5" } androidx-work-runtime = { module = "androidx.work:work-runtime", version = "2.10.5" }
androidx-lifecycle-process = { module = "androidx.lifecycle:lifecycle-process", version = "2.9.4" } androidx-lifecycle-process = { module = "androidx.lifecycle:lifecycle-process", version = "2.9.4" }
androidx-media = { module = "androidx.media:media", version = "1.7.1" } androidx-media = { module = "androidx.media:media", version = "1.7.1" }
androidx-documentfile= { module = "androidx.documentfile:documentfile", version ="1.1.0" }
android-material = { module = "com.google.android.material:material", version = "1.12.0" } android-material = { module = "com.google.android.material:material", version = "1.12.0" }
google-guava = { module = "com.google.guava:guava", version = "33.5.0-android" } google-guava = { module = "com.google.guava:guava", version = "33.4.8-android" }
appdevnext-androidchart = { module = "com.github.AppDevNext:AndroidChart", version = "3.1.0.31" } appdevnext-androidchart = { module = "com.github.AppDevNext:AndroidChart", version = "3.1.0.31" }
androidx-test-junit = { module = "androidx.test.ext:junit", version = "1.3.0" } androidx-test-junit = { module = "androidx.test.ext:junit", version = "1.3.0" }
junit = { module = "junit:junit", version = "4.13.2" } junit = { module = "junit:junit", version = "4.13.2" }
mockito-core = { module = "org.mockito:mockito-core", version = "5.21.0" } mockito-core = { module = "org.mockito:mockito-core", version = "5.20.0" }
[plugins] [plugins]
android-application = { id = "com.android.application", version.ref = "androidGradlePlugin" } android-application = { id = "com.android.application", version.ref = "androidGradlePlugin" }

View File

@@ -126,7 +126,6 @@ dependencies {
implementation libs.androidx.recyclerview implementation libs.androidx.recyclerview
implementation libs.androidx.preference implementation libs.androidx.preference
implementation libs.android.material implementation libs.android.material
implementation libs.androidx.documentfile
testImplementation libs.junit testImplementation libs.junit
} }

View File

@@ -20,8 +20,7 @@ public final class LocationState
} }
@Retention(RetentionPolicy.SOURCE) @Retention(RetentionPolicy.SOURCE)
@IntDef({PENDING_POSITION, NOT_FOLLOW_NO_POSITION, NOT_FOLLOW, FOLLOW, FOLLOW_AND_ROTATE_COMPASS, @IntDef({PENDING_POSITION, NOT_FOLLOW_NO_POSITION, NOT_FOLLOW, FOLLOW, FOLLOW_AND_ROTATE})
FOLLOW_AND_ROTATE_ROUTE})
@interface Value @interface Value
{} {}
@@ -30,8 +29,7 @@ public final class LocationState
public static final int NOT_FOLLOW_NO_POSITION = 1; public static final int NOT_FOLLOW_NO_POSITION = 1;
public static final int NOT_FOLLOW = 2; public static final int NOT_FOLLOW = 2;
public static final int FOLLOW = 3; public static final int FOLLOW = 3;
public static final int FOLLOW_AND_ROTATE_COMPASS = 4; public static final int FOLLOW_AND_ROTATE = 4;
public static final int FOLLOW_AND_ROTATE_ROUTE = 5;
// These constants should correspond to values defined in platform/location.hpp // These constants should correspond to values defined in platform/location.hpp
// Leave 0-value as no any error. // Leave 0-value as no any error.
@@ -71,8 +69,7 @@ public final class LocationState
case NOT_FOLLOW_NO_POSITION -> "NOT_FOLLOW_NO_POSITION"; case NOT_FOLLOW_NO_POSITION -> "NOT_FOLLOW_NO_POSITION";
case NOT_FOLLOW -> "NOT_FOLLOW"; case NOT_FOLLOW -> "NOT_FOLLOW";
case FOLLOW -> "FOLLOW"; case FOLLOW -> "FOLLOW";
case FOLLOW_AND_ROTATE_COMPASS -> "FOLLOW_AND_ROTATE_COMPASS"; case FOLLOW_AND_ROTATE -> "FOLLOW_AND_ROTATE";
case FOLLOW_AND_ROTATE_ROUTE -> "FOLLOW_AND_ROTATE_ROUTE";
default -> "Unknown: " + mode; default -> "Unknown: " + mode;
}; };
} }

View File

@@ -1,10 +1,4 @@
{ {
"World": {
"languages": ["int_name", "en", "default"]
},
"WorldCoasts": {
"languages": ["int_name", "en", "default"]
},
"Abkhazia": { "Abkhazia": {
"languages": ["ab", "ru"] "languages": ["ab", "ru"]
}, },

View File

@@ -1,108 +0,0 @@
{
"make_a_slight_right_turn":"லேசாக வலதுபுறம் திரும்புங்கள்.",
"make_a_slight_right_turn_street":"NULL",
"make_a_slight_right_turn_street_verb":"NULL",
"make_a_right_turn":"வலதுபுறமாக திரும்புங்கள்.",
"make_a_right_turn_street":"NULL",
"make_a_sharp_right_turn":"கூர்மையாக வலதுபுறம் திரும்புங்கள்.",
"make_a_sharp_right_turn_street":"NULL",
"enter_the_roundabout":"ரவுண்டபௌட்டை நுழையுங்கள்.",
"enter_the_roundabout_street":"NULL",
"enter_the_roundabout_street_verb":"NULL",
"leave_the_roundabout":"ரவுண்டபௌட்டை வெளியேறுங்கள்.",
"leave_the_roundabout_street":"NULL",
"leave_the_roundabout_street_verb":"NULL",
"make_a_slight_left_turn":"லேசாக இடதுபுறம் திரும்புங்கள்.",
"make_a_slight_left_turn_street":"NULL",
"make_a_slight_left_turn_street_verb":"NULL",
"make_a_left_turn":"இடதுபுறமாக திரும்புங்கள்.",
"make_a_left_turn_street":"NULL",
"make_a_sharp_left_turn":"கூர்மையாக இடதுபுறம் திரும்புங்கள்.",
"make_a_sharp_left_turn_street":"NULL",
"make_a_u_turn":"U-வழியில் திரும்புங்கள்.",
"make_a_u_turn_street":"NULL",
"make_a_u_turn_street_verb":"NULL",
"go_straight":"நேரா போங்க.",
"exit":"வெளியேறுங்கள்.",
"onto":"நோக்கி",
"take_exit_number":"வெளியேறும் வழி எடுங்கள்",
"take_exit_number_street_verb":"NULL",
"route_recalculating":"வழி மறுபடி கணிக்கிறது",
"destination":"நீங்கள் வருவீர்கள்.",
"you_have_reached_the_destination":"நீங்கள் வந்துவிட்டீர்கள்..",
"in_50_meters":"ஐம்பது மீட்டரில்",
"in_100_meters":"நூறு மீட்டரில்",
"in_200_meters":"இருநூறு மீட்டரில்",
"in_250_meters":"இருநூற்று ஐம்பது மீட்டரில்",
"in_300_meters":"முன்னூறு மீட்டரில்",
"in_400_meters":"நானூறு மீட்டரில்",
"in_500_meters":"ஐநூறு மீட்டரில்",
"in_600_meters":"அறுநூறு மீட்டரில்",
"in_700_meters":"எழுநூறு மீட்டரில்",
"in_750_meters":"எழுநூறு ஐம்பது மீட்டரில்",
"in_800_meters":"எண்ணூறு மீட்டரில்",
"in_900_meters":"தொள்ளாயிரம் மீட்டரில்",
"in_1_kilometer":"ஒரு கிலோமீட்டரில்",
"in_1_5_kilometers":"ஒன்றரை கிலோமீட்டரில்",
"in_2_kilometers":"இரண்டு கிலோமீட்டரில்",
"in_2_5_kilometers":"இரண்டரை கிலோமீட்டரில்",
"in_3_kilometers":"மூன்று கிலோமீட்டரில்",
"then":"அடுத்தது",
"dist_direction_onto_street":"%1$s %4$s %3$s %5$s %2$s",
"take_the_1_exit":"ஒன்றாம் வெளியேறும் வழி எடுங்கள்.",
"take_the_1_exit_street":"NULL",
"take_the_1_exit_street_verb":"NULL",
"take_the_2_exit":"இரண்டாம் வெளியேறும் வழி எடுங்கள்.",
"take_the_2_exit_street":"NULL",
"take_the_2_exit_street_verb":"NULL",
"take_the_3_exit":"மூன்றாம் வெளியேறும் வழி எடுங்கள்.",
"take_the_3_exit_street":"NULL",
"take_the_3_exit_street_verb":"NULL",
"take_the_4_exit":"நான்காவது வெளியேறும் வழி எடுங்கள்.",
"take_the_4_exit_street":"NULL",
"take_the_4_exit_street_verb":"NULL",
"take_the_5_exit":"ஐந்தாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_5_exit_street":"NULL",
"take_the_5_exit_street_verb":"NULL",
"take_the_6_exit":"ஆறாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_6_exit_street":"NULL",
"take_the_6_exit_street_verb":"NULL",
"take_the_7_exit":"ஏழாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_7_exit_street":"NULL",
"take_the_7_exit_street_verb":"NULL",
"take_the_8_exit":"எட்டாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_8_exit_street":"NULL",
"take_the_8_exit_street_verb":"NULL",
"take_the_9_exit":"ஒன்பதாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_9_exit_street":"NULL",
"take_the_9_exit_street_verb":"NULL",
"take_the_10_exit":"பத்தாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_10_exit_street":"NULL",
"take_the_10_exit_street_verb":"NULL",
"take_the_11_exit":"பதினொன்றாவது வெளியேறும் வழி எடுங்கள்.",
"take_the_11_exit_street":"NULL",
"take_the_11_exit_street_verb":"NULL",
"in_50_feet":"ஐம்பது அடியில்",
"in_100_feet":"நூறு அடியில்",
"in_200_feet":"இருநூறு அடியில்",
"in_300_feet":"முன்னூறு அடியில்",
"in_400_feet":"நானூறு அடியில்",
"in_500_feet":"ஐநூறு அடியில்",
"in_600_feet":"அறுநூறு அடியில்",
"in_700_feet":"எழுநூறு அடியில்",
"in_800_feet":"எண்ணூறு அடியில்",
"in_900_feet":"தொள்ளாயிரம் அடியில்",
"in_1000_feet":"ஆயிரம் அடியில்",
"in_1500_feet":"ஆயிரம் ஐநூறு அடியில்",
"in_2000_feet":"இரண்டு ஆயிரம் அடியில்",
"in_2500_feet":"இரண்டு ஆயிரம் ஐநூறு அடியில்",
"in_3000_feet":"மூன்று ஆயிரம் அடியில்",
"in_3500_feet":"மூன்று ஆயிரம் ஐநூறு அடியில்",
"in_4000_feet":"நான்கு ஆயிரம் அடியில்",
"in_4500_feet":"நான்கு ஆயிரம் ஐநூறு அடியில்",
"in_5000_feet":"ஐந்து ஆயிரம் அடியில்",
"in_1_mile":"ஒன்று மைலில்",
"in_1_5_miles":"ஒன்றரை மைலில்",
"in_2_miles":"இரண்டு மைலில்",
"unknown_camera":"கேமரா முன்னால் இருக்கிறது"
}

View File

@@ -1,7 +1,7 @@
{ {
"data_format": 1, "data_format": 1,
"data_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/taginfo.json", "data_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/taginfo.json",
"data_updated": "20251228T203737Z", "data_updated": "20251120T121118Z",
"project": { "project": {
"name": "CoMaps", "name": "CoMaps",
"description": "CoMaps is a community-focused privacy navigation iOS & Android app for travelers - drivers, hikers, and cyclists.", "description": "CoMaps is a community-focused privacy navigation iOS & Android app for travelers - drivers, hikers, and cyclists.",
@@ -176,7 +176,7 @@
"description": "amenity=car_pooling", "description": "amenity=car_pooling",
"key": "amenity", "key": "amenity",
"value": "car_pooling", "value": "car_pooling",
"icon_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/styles/default/light/symbols/parking_pooling-m.svg" "icon_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/styles/default/light/symbols/parking-pooling-m.svg"
}, },
{ {
"description": "amenity=car_rental", "description": "amenity=car_rental",
@@ -431,12 +431,6 @@
"value": "hunting_stand", "value": "hunting_stand",
"icon_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/styles/default/light/symbols/hunting-tower-m.svg" "icon_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/styles/default/light/symbols/hunting-tower-m.svg"
}, },
{
"description": "amenity=hydrant",
"key": "amenity",
"value": "hydrant",
"icon_url": "https://codeberg.org/comaps/comaps/raw/branch/main/data/styles/default/light/symbols/hydrant-m.svg"
},
{ {
"description": "amenity=ice_cream", "description": "amenity=ice_cream",
"key": "amenity", "key": "amenity",

View File

@@ -239,7 +239,7 @@ final class CarPlayService: NSObject {
MapTemplateBuilder.configureBaseUI(mapTemplate: mapTemplate) MapTemplateBuilder.configureBaseUI(mapTemplate: mapTemplate)
if currentPositionMode == .pendingPosition { if currentPositionMode == .pendingPosition {
mapTemplate.leadingNavigationBarButtons = [] mapTemplate.leadingNavigationBarButtons = []
} else if currentPositionMode == .follow || currentPositionMode == .followAndRotateCompass || currentPositionMode == .followAndRotateRoute { } else if currentPositionMode == .follow || currentPositionMode == .followAndRotate {
MapTemplateBuilder.setupDestinationButton(mapTemplate: mapTemplate) MapTemplateBuilder.setupDestinationButton(mapTemplate: mapTemplate)
} else { } else {
MapTemplateBuilder.setupRecenterButton(mapTemplate: mapTemplate) MapTemplateBuilder.setupRecenterButton(mapTemplate: mapTemplate)
@@ -623,32 +623,22 @@ extension CarPlayService: CarPlayRouterListener {
extension CarPlayService: LocationModeListener { extension CarPlayService: LocationModeListener {
func processMyPositionStateModeEvent(_ mode: MWMMyPositionMode) { func processMyPositionStateModeEvent(_ mode: MWMMyPositionMode) {
currentPositionMode = mode currentPositionMode = mode
guard let rootMapTemplate = rootMapTemplate,
// make sure we have a rootMapTemplate let info = rootMapTemplate.userInfo as? MapInfo,
guard let rootMapTemplate = rootMapTemplate else { info.type == CPConstants.TemplateType.main else {
return
}
// exit if we're navigating
guard let info = rootMapTemplate.userInfo as? MapInfo,
info.type == CPConstants.TemplateType.main else {
MapTemplateBuilder.updateMyPositionModeButton(mapTemplate: rootMapTemplate, newMode: mode)
return return
} }
switch mode { switch mode {
case .follow, .followAndRotateCompass, .followAndRotateRoute: case .follow, .followAndRotate:
if !rootMapTemplate.isPanningInterfaceVisible { if !rootMapTemplate.isPanningInterfaceVisible {
MapTemplateBuilder.setupDestinationButton(mapTemplate: rootMapTemplate) MapTemplateBuilder.setupDestinationButton(mapTemplate: rootMapTemplate)
MapTemplateBuilder.updateMyPositionModeButton(mapTemplate: rootMapTemplate, newMode: mode)
} }
case .notFollow: case .notFollow:
if !rootMapTemplate.isPanningInterfaceVisible { if !rootMapTemplate.isPanningInterfaceVisible {
MapTemplateBuilder.setupRecenterButton(mapTemplate: rootMapTemplate) MapTemplateBuilder.setupRecenterButton(mapTemplate: rootMapTemplate)
MapTemplateBuilder.updateMyPositionModeButton(mapTemplate: rootMapTemplate, newMode: mode)
} }
case .pendingPosition, .notFollowNoPosition: case .pendingPosition, .notFollowNoPosition:
rootMapTemplate.leadingNavigationBarButtons = [] rootMapTemplate.leadingNavigationBarButtons = []
MapTemplateBuilder.updateMyPositionModeButton(mapTemplate: rootMapTemplate, newMode: mode)
} }
} }
} }

View File

@@ -5,7 +5,6 @@ final class MapTemplateBuilder {
case startPanning case startPanning
case zoomIn case zoomIn
case zoomOut case zoomOut
case myPositionMode
} }
enum BarButtonType { enum BarButtonType {
case dismissPaning case dismissPaning
@@ -29,7 +28,7 @@ final class MapTemplateBuilder {
configureBaseUI(mapTemplate: mapTemplate) configureBaseUI(mapTemplate: mapTemplate)
if positionMode == .pendingPosition { if positionMode == .pendingPosition {
mapTemplate.leadingNavigationBarButtons = [] mapTemplate.leadingNavigationBarButtons = []
} else if positionMode == .follow || positionMode == .followAndRotateCompass || positionMode == .followAndRotateRoute { } else if positionMode == .follow || positionMode == .followAndRotate {
setupDestinationButton(mapTemplate: mapTemplate) setupDestinationButton(mapTemplate: mapTemplate)
} else { } else {
setupRecenterButton(mapTemplate: mapTemplate) setupRecenterButton(mapTemplate: mapTemplate)
@@ -70,10 +69,7 @@ final class MapTemplateBuilder {
let zoomOutButton = buildMapButton(type: .zoomOut) { _ in let zoomOutButton = buildMapButton(type: .zoomOut) { _ in
FrameworkHelper.zoomMap(.out) FrameworkHelper.zoomMap(.out)
} }
let myPositionModeButton = buildMapButton(type: .myPositionMode) { _ in mapTemplate.mapButtons = [panningButton, zoomInButton, zoomOutButton]
FrameworkHelper.switchMyPositionMode()
}
mapTemplate.mapButtons = [myPositionModeButton, panningButton, zoomInButton, zoomOutButton]
let settingsButton = buildBarButton(type: .settings) { _ in let settingsButton = buildBarButton(type: .settings) { _ in
let gridTemplate = SettingsTemplateBuilder.buildGridTemplate() let gridTemplate = SettingsTemplateBuilder.buildGridTemplate()
@@ -103,10 +99,7 @@ final class MapTemplateBuilder {
let panningButton = buildMapButton(type: .startPanning) { _ in let panningButton = buildMapButton(type: .startPanning) { _ in
mapTemplate.showPanningInterface(animated: true) mapTemplate.showPanningInterface(animated: true)
} }
let myPositionModeButton = buildMapButton(type: .myPositionMode) { _ in mapTemplate.mapButtons = [panningButton]
FrameworkHelper.switchMyPositionMode()
}
mapTemplate.mapButtons = [myPositionModeButton, panningButton]
setupMuteAndRedirectButtons(template: mapTemplate) setupMuteAndRedirectButtons(template: mapTemplate)
let endButton = buildBarButton(type: .endRoute) { _ in let endButton = buildBarButton(type: .endRoute) { _ in
CarPlayService.shared.cancelCurrentTrip() CarPlayService.shared.cancelCurrentTrip()
@@ -124,28 +117,6 @@ final class MapTemplateBuilder {
mapTemplate.leadingNavigationBarButtons = [destinationButton] mapTemplate.leadingNavigationBarButtons = [destinationButton]
} }
class func updateMyPositionModeButton(mapTemplate: CPMapTemplate, newMode: MWMMyPositionMode) {
let button = CPMapButton(handler: { _ in
FrameworkHelper.switchMyPositionMode()
})
switch newMode {
case .pendingPosition:
button.image = UIImage(systemName: "location.fill")
case .notFollowNoPosition:
button.image = UIImage(systemName: "location")
case .notFollow:
button.image = UIImage(systemName: "location")
case .follow:
button.image = UIImage(systemName: "location.fill")
case .followAndRotate:
button.image = UIImage(systemName: "location.north.line.fill")
}
if mapTemplate.mapButtons.count > 0 {
mapTemplate.mapButtons[0] = button
}
}
class func setupRecenterButton(mapTemplate: CPMapTemplate) { class func setupRecenterButton(mapTemplate: CPMapTemplate) {
let recenterButton = buildBarButton(type: .recenter) { _ in let recenterButton = buildBarButton(type: .recenter) { _ in
FrameworkHelper.switchMyPositionMode() FrameworkHelper.switchMyPositionMode()
@@ -195,8 +166,6 @@ final class MapTemplateBuilder {
button.image = UIImage(systemName: "plus") button.image = UIImage(systemName: "plus")
case .zoomOut: case .zoomOut:
button.image = UIImage(systemName: "minus") button.image = UIImage(systemName: "minus")
case .myPositionMode:
button.image = UIImage(systemName: "location")
} }
// Remove code below once Apple has fixed its issue with the button background // Remove code below once Apple has fixed its issue with the button background
if #unavailable(iOS 26) { if #unavailable(iOS 26) {
@@ -207,8 +176,6 @@ final class MapTemplateBuilder {
button.focusedImage = UIImage(systemName: "plus.circle.fill") button.focusedImage = UIImage(systemName: "plus.circle.fill")
case .zoomOut: case .zoomOut:
button.focusedImage = UIImage(systemName: "minus.circle.fill") button.focusedImage = UIImage(systemName: "minus.circle.fill")
case .myPositionMode:
button.image = UIImage(systemName: "location.fill")
} }
} }
return button return button

View File

@@ -91,8 +91,7 @@ NSString * const kUDDidShowLongTapToShowSideButtonsToast = @"kUDDidShowLongTapTo
case MWMMyPositionModeNotFollow: case MWMMyPositionModeNotFollow:
case MWMMyPositionModeNotFollowNoPosition: [locBtn setStyleNameAndApply: @"ButtonGetPosition"]; break; case MWMMyPositionModeNotFollowNoPosition: [locBtn setStyleNameAndApply: @"ButtonGetPosition"]; break;
case MWMMyPositionModeFollow: [locBtn setStyleNameAndApply: @"ButtonFollow"]; break; case MWMMyPositionModeFollow: [locBtn setStyleNameAndApply: @"ButtonFollow"]; break;
case MWMMyPositionModeFollowAndRotateCompass: [locBtn setStyleNameAndApply: @"ButtonFollowAndRotateCompass"]; break; case MWMMyPositionModeFollowAndRotate: [locBtn setStyleNameAndApply: @"ButtonFollowAndRotate"]; break;
case MWMMyPositionModeFollowAndRotateRoute: [locBtn setStyleNameAndApply: @"ButtonFollowAndRotateRoute"]; break;
} }
} }

View File

@@ -632,8 +632,7 @@ NSString *const kAboutSegue = @"Map2About";
case MWMMyPositionModeNotFollow: case MWMMyPositionModeNotFollow:
break; break;
case MWMMyPositionModeFollow: case MWMMyPositionModeFollow:
case MWMMyPositionModeFollowAndRotateCompass: case MWMMyPositionModeFollowAndRotate:
case MWMMyPositionModeFollowAndRotateRoute:
self.disableStandbyOnLocationStateMode = YES; self.disableStandbyOnLocationStateMode = YES;
break; break;
} }

View File

@@ -32,8 +32,7 @@ static inline MWMMyPositionMode mwmMyPositionMode(location::EMyPositionMode mode
case location::EMyPositionMode::NotFollowNoPosition: return MWMMyPositionModeNotFollowNoPosition; case location::EMyPositionMode::NotFollowNoPosition: return MWMMyPositionModeNotFollowNoPosition;
case location::EMyPositionMode::NotFollow: return MWMMyPositionModeNotFollow; case location::EMyPositionMode::NotFollow: return MWMMyPositionModeNotFollow;
case location::EMyPositionMode::Follow: return MWMMyPositionModeFollow; case location::EMyPositionMode::Follow: return MWMMyPositionModeFollow;
case location::EMyPositionMode::FollowAndRotateCompass: return MWMMyPositionModeFollowAndRotateCompass; case location::EMyPositionMode::FollowAndRotate: return MWMMyPositionModeFollowAndRotate;
case location::EMyPositionMode::FollowAndRotateRoute: return MWMMyPositionModeFollowAndRotateRoute;
} }
} }
} // namespace location_helpers } // namespace location_helpers

View File

@@ -50,8 +50,7 @@ std::string DebugPrint(MWMMyPositionMode mode) {
case MWMMyPositionModeNotFollowNoPosition: return "MWMMyPositionModeNotFollowNoPosition"; case MWMMyPositionModeNotFollowNoPosition: return "MWMMyPositionModeNotFollowNoPosition";
case MWMMyPositionModeNotFollow: return "MWMMyPositionModeNotFollow"; case MWMMyPositionModeNotFollow: return "MWMMyPositionModeNotFollow";
case MWMMyPositionModeFollow: return "MWMMyPositionModeFollow"; case MWMMyPositionModeFollow: return "MWMMyPositionModeFollow";
case MWMMyPositionModeFollowAndRotateCompass: return "MWMMyPositionModeFollowAndRotateCompass"; case MWMMyPositionModeFollowAndRotate: return "MWMMyPositionModeFollowAndRotate";
case MWMMyPositionModeFollowAndRotateRoute: return "MWMMyPositionModeFollowAndRotateRoute";
} }
CHECK(false, ("Unsupported value", static_cast<int>(mode))); CHECK(false, ("Unsupported value", static_cast<int>(mode)));
} }
@@ -368,8 +367,7 @@ void setShowLocationAlert(BOOL needShow) {
case MWMMyPositionModeNotFollowNoPosition: case MWMMyPositionModeNotFollowNoPosition:
case MWMMyPositionModeNotFollow: manager.geoMode = GeoMode::NotInPosition; break; case MWMMyPositionModeNotFollow: manager.geoMode = GeoMode::NotInPosition; break;
case MWMMyPositionModeFollow: manager.geoMode = GeoMode::InPosition; break; case MWMMyPositionModeFollow: manager.geoMode = GeoMode::InPosition; break;
case MWMMyPositionModeFollowAndRotateCompass: case MWMMyPositionModeFollowAndRotate: manager.geoMode = GeoMode::FollowAndRotate; break;
case MWMMyPositionModeFollowAndRotateRoute: manager.geoMode = GeoMode::FollowAndRotate; break;
} }
} }
} }

View File

@@ -30,7 +30,7 @@ NSUInteger constexpr kMaxPredictionCount = 20;
- (void)setMyPositionMode:(MWMMyPositionMode)mode - (void)setMyPositionMode:(MWMMyPositionMode)mode
{ {
self.isLastPositionModeValid = (mode == MWMMyPositionModeFollowAndRotateCompass); self.isLastPositionModeValid = (mode == MWMMyPositionModeFollowAndRotate);
[self restart]; [self restart];
} }

View File

@@ -3,6 +3,5 @@ typedef NS_CLOSED_ENUM(NSUInteger, MWMMyPositionMode) {
MWMMyPositionModeNotFollowNoPosition, MWMMyPositionModeNotFollowNoPosition,
MWMMyPositionModeNotFollow, MWMMyPositionModeNotFollow,
MWMMyPositionModeFollow, MWMMyPositionModeFollow,
MWMMyPositionModeFollowAndRotateCompass, MWMMyPositionModeFollowAndRotate
MWMMyPositionModeFollowAndRotateRoute
}; };

View File

@@ -41,14 +41,13 @@ final class ThemeManager: NSObject {
} }
}(actualTheme) }(actualTheme)
let isCarPlayActive = CarPlayService.shared.isCarplayActivated if Settings.mapAppearance == .light {
if !isCarPlayActive, Settings.mapAppearance == .light {
if actualTheme == .vehicleDay || actualTheme == .vehicleNight { if actualTheme == .vehicleDay || actualTheme == .vehicleNight {
FrameworkHelper.setTheme(.vehicleDay) FrameworkHelper.setTheme(.vehicleDay)
} else { } else {
FrameworkHelper.setTheme(.day) FrameworkHelper.setTheme(.day)
} }
} else if !isCarPlayActive, Settings.mapAppearance == .dark { } else if Settings.mapAppearance == .dark {
if actualTheme == .vehicleDay || actualTheme == .vehicleNight { if actualTheme == .vehicleDay || actualTheme == .vehicleNight {
FrameworkHelper.setTheme(.vehicleNight) FrameworkHelper.setTheme(.vehicleNight)
} else { } else {

View File

@@ -7,8 +7,7 @@ enum MapStyleSheet: String, CaseIterable {
case mapButtonPending = "ButtonPending" case mapButtonPending = "ButtonPending"
case mapButtonGetPosition = "ButtonGetPosition" case mapButtonGetPosition = "ButtonGetPosition"
case mapButtonFollow = "ButtonFollow" case mapButtonFollow = "ButtonFollow"
case mapButtonFollowAndRotateCompass = "ButtonFollowAndRotateCompass" case mapButtonFollowAndRotate = "ButtonFollowAndRotate"
case mapButtonFollowAndRotateRoute = "ButtonFollowAndRotateRoute"
case mapButtonMapBookmarks = "ButtonMapBookmarks" case mapButtonMapBookmarks = "ButtonMapBookmarks"
case mapPromoDiscoveryButton = "PromoDiscroveryButton" case mapPromoDiscoveryButton = "PromoDiscroveryButton"
case mapButtonBookmarksBack = "ButtonBookmarksBack" case mapButtonBookmarksBack = "ButtonBookmarksBack"
@@ -68,14 +67,10 @@ extension MapStyleSheet: IStyleSheet {
return .add { s in return .add { s in
s.mwmImage = "btn_follow" s.mwmImage = "btn_follow"
} }
case .mapButtonFollowAndRotateCompass: case .mapButtonFollowAndRotate:
return .add { s in return .add { s in
s.mwmImage = "btn_follow_and_rotate" s.mwmImage = "btn_follow_and_rotate"
} }
case .mapButtonFollowAndRotateRoute:
return .add { s in
s.mwmImage = "btn_follow_route"
}
case .mapButtonMapBookmarks: case .mapButtonMapBookmarks:
return .add { s in return .add { s in
s.mwmImage = "ic_routing_bookmark" s.mwmImage = "ic_routing_bookmark"

View File

@@ -1,6 +1,6 @@
{ {
"info" : { "info" : {
"author" : "xcode", "version" : 1,
"version" : 1 "author" : "xcode"
} }
} }

View File

@@ -1,21 +0,0 @@
{
"images" : [
{
"idiom" : "universal",
"scale" : "1x"
},
{
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "btn_follow_route_dark.png",
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 12 KiB

View File

@@ -1,21 +0,0 @@
{
"images" : [
{
"idiom" : "universal",
"scale" : "1x"
},
{
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "btn_follow_route_highlighted_dark.png",
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}

View File

@@ -1,21 +0,0 @@
{
"images" : [
{
"idiom" : "universal",
"scale" : "1x"
},
{
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "btn_follow_route_highlighted_light.png",
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}

View File

@@ -1,21 +0,0 @@
{
"images" : [
{
"idiom" : "universal",
"scale" : "1x"
},
{
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "btn_follow_route_light.png",
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 12 KiB

View File

@@ -186,7 +186,7 @@ import AVFoundation
return mapAppearance return mapAppearance
} }
return .light return .auto
} }
set { set {
UserDefaults.standard.set(newValue.rawValue, forKey: userDefaultsKeyMapAppearance) UserDefaults.standard.set(newValue.rawValue, forKey: userDefaultsKeyMapAppearance)

View File

@@ -9,7 +9,6 @@
#include "drape/support_manager.hpp" #include "drape/support_manager.hpp"
#include "platform/settings.hpp" #include "platform/settings.hpp"
#include "routing/base/followed_polyline.hpp"
#include <unordered_map> #include <unordered_map>
@@ -41,7 +40,7 @@ DrapeEngine::DrapeEngine(Params && params)
using namespace location; using namespace location;
EMyPositionMode mode = PendingPosition; EMyPositionMode mode = PendingPosition;
if (settings::Get(kLocationStateMode, mode) && mode == FollowAndRotateCompass) if (settings::Get(kLocationStateMode, mode) && mode == FollowAndRotate)
{ {
// If the screen rect setting in follow and rotate mode is missing or invalid, it could cause // If the screen rect setting in follow and rotate mode is missing or invalid, it could cause
// invalid animations, so the follow and rotate mode should be discarded. // invalid animations, so the follow and rotate mode should be discarded.
@@ -442,12 +441,13 @@ void DrapeEngine::SetCompassInfo(location::CompassInfo const & info)
MessagePriority::Normal); MessagePriority::Normal);
} }
void DrapeEngine::SetGpsInfo(location::GpsInfo const & info, df::NavigationContext const & navigationContext, void DrapeEngine::SetGpsInfo(location::GpsInfo const & info, bool isNavigable, double distToNextTurn, double speedLimit,
location::RouteMatchingInfo const & routeInfo) location::RouteMatchingInfo const & routeInfo)
{ {
m_threadCommutator->PostMessage(ThreadsCommutator::RenderThread, m_threadCommutator->PostMessage(
make_unique_dp<GpsInfoMessage>(info, navigationContext, routeInfo), ThreadsCommutator::RenderThread,
MessagePriority::Normal); make_unique_dp<GpsInfoMessage>(info, isNavigable, distToNextTurn, speedLimit, routeInfo),
MessagePriority::Normal);
} }
void DrapeEngine::SwitchMyPositionNextMode() void DrapeEngine::SwitchMyPositionNextMode()
@@ -474,13 +474,12 @@ void DrapeEngine::StopLocationFollow()
MessagePriority::Normal); MessagePriority::Normal);
} }
void DrapeEngine::FollowRoute(int preferredZoomLevel, int preferredZoomLevel3d, bool enableAutoZoom, bool isArrowGlued, void DrapeEngine::FollowRoute(int preferredZoomLevel, int preferredZoomLevel3d, bool enableAutoZoom, bool isArrowGlued)
bool allowRouteRotation)
{ {
m_threadCommutator->PostMessage(ThreadsCommutator::RenderThread, m_threadCommutator->PostMessage(
make_unique_dp<FollowRouteMessage>(preferredZoomLevel, preferredZoomLevel3d, ThreadsCommutator::RenderThread,
enableAutoZoom, isArrowGlued, allowRouteRotation), make_unique_dp<FollowRouteMessage>(preferredZoomLevel, preferredZoomLevel3d, enableAutoZoom, isArrowGlued),
MessagePriority::Normal); MessagePriority::Normal);
} }
void DrapeEngine::SetModelViewListener(ModelViewChangedHandler && fn) void DrapeEngine::SetModelViewListener(ModelViewChangedHandler && fn)

View File

@@ -1,7 +1,5 @@
#pragma once #pragma once
#include "drape_frontend/my_position_controller.hpp"
#include "routing/base/followed_polyline.hpp"
#include "traffic/traffic_info.hpp" #include "traffic/traffic_info.hpp"
#include "drape_frontend/backend_renderer.hpp" #include "drape_frontend/backend_renderer.hpp"
@@ -156,7 +154,7 @@ public:
void UpdateMapStyle(); void UpdateMapStyle();
void SetCompassInfo(location::CompassInfo const & info); void SetCompassInfo(location::CompassInfo const & info);
void SetGpsInfo(location::GpsInfo const & info, df::NavigationContext const & navigationContext, void SetGpsInfo(location::GpsInfo const & info, bool isNavigable, double distToNextTurn, double speedLimit,
location::RouteMatchingInfo const & routeInfo); location::RouteMatchingInfo const & routeInfo);
void SwitchMyPositionNextMode(); void SwitchMyPositionNextMode();
void LoseLocation(); void LoseLocation();
@@ -173,8 +171,7 @@ public:
dp::DrapeID AddSubroute(SubrouteConstPtr subroute); dp::DrapeID AddSubroute(SubrouteConstPtr subroute);
void RemoveSubroute(dp::DrapeID subrouteId, bool deactivateFollowing); void RemoveSubroute(dp::DrapeID subrouteId, bool deactivateFollowing);
void FollowRoute(int preferredZoomLevel, int preferredZoomLevel3d, bool enableAutoZoom, bool isArrowGlued, void FollowRoute(int preferredZoomLevel, int preferredZoomLevel3d, bool enableAutoZoom, bool isArrowGlued);
bool allowRouteRotation);
void DeactivateRouteFollowing(); void DeactivateRouteFollowing();
void SetSubrouteVisibility(dp::DrapeID subrouteId, bool isVisible); void SetSubrouteVisibility(dp::DrapeID subrouteId, bool isVisible);
dp::DrapeID AddRoutePreviewSegment(m2::PointD const & startPt, m2::PointD const & finishPt); dp::DrapeID AddRoutePreviewSegment(m2::PointD const & startPt, m2::PointD const & finishPt);

View File

@@ -438,8 +438,8 @@ void FrontendRenderer::AcceptMessage(ref_ptr<Message> message)
break; break;
#endif #endif
ref_ptr<GpsInfoMessage> msg = message; ref_ptr<GpsInfoMessage> msg = message;
m_myPositionController->OnLocationUpdate(msg->GetInfo(), msg->GetNavigationContext(), m_myPositionController->OnLocationUpdate(msg->GetInfo(), msg->IsNavigable(), msg->GetDistanceToNextTurn(),
m_userEventStream.GetCurrentScreen()); msg->GetSpeedLimit(), m_userEventStream.GetCurrentScreen());
location::RouteMatchingInfo const & info = msg->GetRouteInfo(); location::RouteMatchingInfo const & info = msg->GetRouteInfo();
if (info.HasDistanceFromBegin()) if (info.HasDistanceFromBegin())
@@ -512,8 +512,7 @@ void FrontendRenderer::AcceptMessage(ref_ptr<Message> message)
if (m_pendingFollowRoute != nullptr) if (m_pendingFollowRoute != nullptr)
{ {
FollowRoute(m_pendingFollowRoute->m_preferredZoomLevel, m_pendingFollowRoute->m_preferredZoomLevelIn3d, FollowRoute(m_pendingFollowRoute->m_preferredZoomLevel, m_pendingFollowRoute->m_preferredZoomLevelIn3d,
m_pendingFollowRoute->m_enableAutoZoom, m_pendingFollowRoute->m_isArrowGlued, m_pendingFollowRoute->m_enableAutoZoom, m_pendingFollowRoute->m_isArrowGlued);
m_pendingFollowRoute->m_allowRouteRotation);
m_pendingFollowRoute.reset(); m_pendingFollowRoute.reset();
} }
break; break;
@@ -585,14 +584,13 @@ void FrontendRenderer::AcceptMessage(ref_ptr<Message> message)
// receive FollowRoute message before FlushSubroute message, so we need to postpone its processing. // receive FollowRoute message before FlushSubroute message, so we need to postpone its processing.
if (m_routeRenderer->GetSubroutes().empty()) if (m_routeRenderer->GetSubroutes().empty())
{ {
m_pendingFollowRoute = m_pendingFollowRoute = std::make_unique<FollowRouteData>(
std::make_unique<FollowRouteData>(msg->GetPreferredZoomLevel(), msg->GetPreferredZoomLevelIn3d(), msg->GetPreferredZoomLevel(), msg->GetPreferredZoomLevelIn3d(), msg->EnableAutoZoom(), msg->IsArrowGlued());
msg->EnableAutoZoom(), msg->IsArrowGlued(), msg->AllowRouteRotation());
} }
else else
{ {
FollowRoute(msg->GetPreferredZoomLevel(), msg->GetPreferredZoomLevelIn3d(), msg->EnableAutoZoom(), FollowRoute(msg->GetPreferredZoomLevel(), msg->GetPreferredZoomLevelIn3d(), msg->EnableAutoZoom(),
msg->IsArrowGlued(), msg->AllowRouteRotation()); msg->IsArrowGlued());
} }
break; break;
} }
@@ -1059,11 +1057,10 @@ void FrontendRenderer::UpdateContextDependentResources()
} }
void FrontendRenderer::FollowRoute(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, void FrontendRenderer::FollowRoute(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom,
bool isArrowGlued, bool allowRouteRotation) bool isArrowGlued)
{ {
m_myPositionController->ActivateRouting( m_myPositionController->ActivateRouting(
!m_enablePerspectiveInNavigation ? preferredZoomLevel : preferredZoomLevelIn3d, enableAutoZoom, isArrowGlued, !m_enablePerspectiveInNavigation ? preferredZoomLevel : preferredZoomLevelIn3d, enableAutoZoom, isArrowGlued);
allowRouteRotation);
if (m_enablePerspectiveInNavigation) if (m_enablePerspectiveInNavigation)
AddUserEvent(make_unique_dp<SetAutoPerspectiveEvent>(true /* isAutoPerspective */)); AddUserEvent(make_unique_dp<SetAutoPerspectiveEvent>(true /* isAutoPerspective */));

View File

@@ -261,8 +261,7 @@ private:
using TRenderGroupRemovePredicate = std::function<bool(drape_ptr<RenderGroup> const &)>; using TRenderGroupRemovePredicate = std::function<bool(drape_ptr<RenderGroup> const &)>;
void RemoveRenderGroupsLater(TRenderGroupRemovePredicate const & predicate); void RemoveRenderGroupsLater(TRenderGroupRemovePredicate const & predicate);
void FollowRoute(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued, void FollowRoute(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued);
bool allowRouteRotation);
bool CheckRouteRecaching(ref_ptr<BaseSubrouteData> subrouteData); bool CheckRouteRecaching(ref_ptr<BaseSubrouteData> subrouteData);
@@ -373,20 +372,17 @@ private:
struct FollowRouteData struct FollowRouteData
{ {
FollowRouteData(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued, FollowRouteData(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued)
bool allowRouteRotation)
: m_preferredZoomLevel(preferredZoomLevel) : m_preferredZoomLevel(preferredZoomLevel)
, m_preferredZoomLevelIn3d(preferredZoomLevelIn3d) , m_preferredZoomLevelIn3d(preferredZoomLevelIn3d)
, m_enableAutoZoom(enableAutoZoom) , m_enableAutoZoom(enableAutoZoom)
, m_isArrowGlued(isArrowGlued) , m_isArrowGlued(isArrowGlued)
, m_allowRouteRotation(allowRouteRotation)
{} {}
int m_preferredZoomLevel; int m_preferredZoomLevel;
int m_preferredZoomLevelIn3d; int m_preferredZoomLevelIn3d;
bool m_enableAutoZoom; bool m_enableAutoZoom;
bool m_isArrowGlued; bool m_isArrowGlued;
bool m_allowRouteRotation;
}; };
std::unique_ptr<FollowRouteData> m_pendingFollowRoute; std::unique_ptr<FollowRouteData> m_pendingFollowRoute;

View File

@@ -10,7 +10,6 @@
#include "drape_frontend/gui/skin.hpp" #include "drape_frontend/gui/skin.hpp"
#include "drape_frontend/message.hpp" #include "drape_frontend/message.hpp"
#include "drape_frontend/my_position.hpp" #include "drape_frontend/my_position.hpp"
#include "drape_frontend/my_position_controller.hpp"
#include "drape_frontend/overlay_batcher.hpp" #include "drape_frontend/overlay_batcher.hpp"
#include "drape_frontend/postprocess_renderer.hpp" #include "drape_frontend/postprocess_renderer.hpp"
#include "drape_frontend/render_node.hpp" #include "drape_frontend/render_node.hpp"
@@ -30,7 +29,6 @@
#include "geometry/rect2d.hpp" #include "geometry/rect2d.hpp"
#include "geometry/triangle2d.hpp" #include "geometry/triangle2d.hpp"
#include "routing/base/followed_polyline.hpp"
#include <condition_variable> #include <condition_variable>
#include <functional> #include <functional>
@@ -477,22 +475,28 @@ private:
class GpsInfoMessage : public Message class GpsInfoMessage : public Message
{ {
public: public:
GpsInfoMessage(location::GpsInfo const & info, df::NavigationContext const & navigationContext, GpsInfoMessage(location::GpsInfo const & info, bool isNavigable, double distToNextTurn, double speedLimit,
location::RouteMatchingInfo const & routeInfo) location::RouteMatchingInfo const & routeInfo)
: m_info(info) : m_info(info)
, m_navigationContext(navigationContext) , m_isNavigable(isNavigable)
, m_distToNextTurn(distToNextTurn)
, m_speedLimit(speedLimit)
, m_routeInfo(routeInfo) , m_routeInfo(routeInfo)
{} {}
Type GetType() const override { return Type::GpsInfo; } Type GetType() const override { return Type::GpsInfo; }
location::GpsInfo const & GetInfo() const { return m_info; } location::GpsInfo const & GetInfo() const { return m_info; }
df::NavigationContext const & GetNavigationContext() const { return m_navigationContext; } bool IsNavigable() const { return m_isNavigable; }
double const & GetSpeedLimit() const { return m_speedLimit; }
double const & GetDistanceToNextTurn() const { return m_distToNextTurn; }
location::RouteMatchingInfo const & GetRouteInfo() const { return m_routeInfo; } location::RouteMatchingInfo const & GetRouteInfo() const { return m_routeInfo; }
private: private:
location::GpsInfo const m_info; location::GpsInfo const m_info;
df::NavigationContext const m_navigationContext; bool const m_isNavigable;
double const m_distToNextTurn;
double const m_speedLimit;
location::RouteMatchingInfo const m_routeInfo; location::RouteMatchingInfo const m_routeInfo;
}; };
@@ -736,13 +740,11 @@ public:
class FollowRouteMessage : public Message class FollowRouteMessage : public Message
{ {
public: public:
FollowRouteMessage(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued, FollowRouteMessage(int preferredZoomLevel, int preferredZoomLevelIn3d, bool enableAutoZoom, bool isArrowGlued)
bool allowRouteRotation)
: m_preferredZoomLevel(preferredZoomLevel) : m_preferredZoomLevel(preferredZoomLevel)
, m_preferredZoomLevelIn3d(preferredZoomLevelIn3d) , m_preferredZoomLevelIn3d(preferredZoomLevelIn3d)
, m_enableAutoZoom(enableAutoZoom) , m_enableAutoZoom(enableAutoZoom)
, m_isArrowGlued(isArrowGlued) , m_isArrowGlued(isArrowGlued)
, m_allowRouteRotation(allowRouteRotation)
{} {}
Type GetType() const override { return Type::FollowRoute; } Type GetType() const override { return Type::FollowRoute; }
@@ -751,14 +753,12 @@ public:
int GetPreferredZoomLevelIn3d() const { return m_preferredZoomLevelIn3d; } int GetPreferredZoomLevelIn3d() const { return m_preferredZoomLevelIn3d; }
bool EnableAutoZoom() const { return m_enableAutoZoom; } bool EnableAutoZoom() const { return m_enableAutoZoom; }
bool IsArrowGlued() const { return m_isArrowGlued; } bool IsArrowGlued() const { return m_isArrowGlued; }
bool AllowRouteRotation() const { return m_allowRouteRotation; }
private: private:
int const m_preferredZoomLevel; int const m_preferredZoomLevel;
int const m_preferredZoomLevelIn3d; int const m_preferredZoomLevelIn3d;
bool const m_enableAutoZoom; bool const m_enableAutoZoom;
bool const m_isArrowGlued; bool const m_isArrowGlued;
bool const m_allowRouteRotation;
}; };
class SwitchMapStyleMessage : public BaseBlockingMessage class SwitchMapStyleMessage : public BaseBlockingMessage

View File

@@ -9,11 +9,9 @@
#include "geometry/mercator.hpp" #include "geometry/mercator.hpp"
#include "platform/location.hpp"
#include "platform/measurement_utils.hpp" #include "platform/measurement_utils.hpp"
#include "base/math.hpp" #include "base/math.hpp"
#include "routing/base/followed_polyline.hpp"
#include <algorithm> #include <algorithm>
#include <array> #include <array>
@@ -33,9 +31,6 @@ double constexpr kMaxTimeInBackgroundSec = 60.0 * 60 * 30; // 30 hours before s
double constexpr kMaxNotFollowRoutingTimeSec = 20.0; double constexpr kMaxNotFollowRoutingTimeSec = 20.0;
double constexpr kMaxUpdateLocationInvervalSec = 30.0; double constexpr kMaxUpdateLocationInvervalSec = 30.0;
double constexpr kMaxBlockAutoZoomTimeSec = 10.0; double constexpr kMaxBlockAutoZoomTimeSec = 10.0;
double constexpr kDefaultSpeedLimitKmpH = 50.0;
double constexpr kLookaheadTimeSpeedRatio = 0.3;
double constexpr kMaxLookaheadTimeSec = 25.0;
int constexpr kZoomThreshold = 10; int constexpr kZoomThreshold = 10;
int constexpr kMaxScaleZoomLevel = 16; int constexpr kMaxScaleZoomLevel = 16;
@@ -71,6 +66,7 @@ double CalculateZoomByMaxSpeed(double speedMpS, bool isPerspectiveAllowed)
std::array<TSpeedScale, 2> const & scales = isPerspectiveAllowed ? scales3d : scales2d; std::array<TSpeedScale, 2> const & scales = isPerspectiveAllowed ? scales3d : scales2d;
double constexpr kDefaultSpeedLimitKmpH = 50.0;
double const speedKmpH = speedMpS > 0 ? measurement_utils::MpsToKmph(speedMpS) : kDefaultSpeedLimitKmpH; double const speedKmpH = speedMpS > 0 ? measurement_utils::MpsToKmph(speedMpS) : kDefaultSpeedLimitKmpH;
size_t i = 0; size_t i = 0;
@@ -147,7 +143,7 @@ void ResetNotification(uint64_t & notifyId)
bool IsModeChangeViewport(location::EMyPositionMode mode) bool IsModeChangeViewport(location::EMyPositionMode mode)
{ {
return mode == location::Follow || mode == location::FollowAndRotateCompass || mode == location::FollowAndRotateRoute; return mode == location::Follow || mode == location::FollowAndRotate;
} }
} // namespace } // namespace
@@ -161,11 +157,9 @@ MyPositionController::MyPositionController(Params && params, ref_ptr<DrapeNotifi
, m_errorRadius(0.0) , m_errorRadius(0.0)
, m_horizontalAccuracy(0.0) , m_horizontalAccuracy(0.0)
, m_position(m2::PointD::Zero()) , m_position(m2::PointD::Zero())
, m_direction(0.0) , m_drawDirection(0.0)
, m_routeDirection(0.0)
, m_arrowDirection(0.0)
, m_oldPosition(m2::PointD::Zero()) , m_oldPosition(m2::PointD::Zero())
, m_oldArrowDirection(0.0) , m_oldDrawDirection(0.0)
, m_enablePerspectiveInRouting(false) , m_enablePerspectiveInRouting(false)
, m_enableAutoZoomInRouting(params.m_isAutozoomEnabled) , m_enableAutoZoomInRouting(params.m_isAutozoomEnabled)
, m_autoScale2d(GetScreenScale(kDefaultAutoZoom)) , m_autoScale2d(GetScreenScale(kDefaultAutoZoom))
@@ -177,8 +171,7 @@ MyPositionController::MyPositionController(Params && params, ref_ptr<DrapeNotifi
, m_isDirtyAutoZoom(false) , m_isDirtyAutoZoom(false)
, m_isPendingAnimation(false) , m_isPendingAnimation(false)
, m_isPositionAssigned(false) , m_isPositionAssigned(false)
, m_isArrowDirectionAssigned(false) , m_isDirectionAssigned(false)
, m_isRouteDirectionAssigned(false)
, m_isCompassAvailable(false) , m_isCompassAvailable(false)
, m_positionIsObsolete(false) , m_positionIsObsolete(false)
, m_needBlockAutoZoom(false) , m_needBlockAutoZoom(false)
@@ -297,7 +290,7 @@ void MyPositionController::ScaleEnded()
void MyPositionController::Rotated() void MyPositionController::Rotated()
{ {
if (m_mode == location::FollowAndRotateCompass) if (m_mode == location::FollowAndRotate)
m_wasRotationInScaling = true; m_wasRotationInScaling = true;
} }
@@ -405,32 +398,25 @@ void MyPositionController::NextMode(ScreenBase const & screen)
// In routing not-follow -> follow-and-rotate, otherwise not-follow -> follow. // In routing not-follow -> follow-and-rotate, otherwise not-follow -> follow.
if (m_mode == location::NotFollow) if (m_mode == location::NotFollow)
{ {
ChangeMode(m_isInRouting ? location::FollowAndRotateCompass : location::Follow); ChangeMode(m_isInRouting ? location::FollowAndRotate : location::Follow);
UpdateViewport(preferredZoomLevel); UpdateViewport(preferredZoomLevel);
return; return;
} }
// From follow mode we transit to follow-and-rotate-compass, if in routing // From follow mode we transit to follow-and-rotate if compass is available or
// routing is enabled.
if (m_mode == location::Follow) if (m_mode == location::Follow)
{ {
if (IsArrowRotationAvailable() || m_isInRouting) if (IsRotationAvailable() || m_isInRouting)
{ {
ChangeMode(location::FollowAndRotateCompass); ChangeMode(location::FollowAndRotate);
UpdateViewport(preferredZoomLevel); UpdateViewport(preferredZoomLevel);
} }
return; return;
} }
// From -rotate-compass mode we transit to -rotate-route mode, if allowed // From follow-and-rotate mode we can transit to follow mode.
if (m_mode == location::FollowAndRotateCompass && IsRouteRotationAvailable() && m_allowRouteRotationInRouting) if (m_mode == location::FollowAndRotate)
{
ChangeMode(location::FollowAndRotateRoute);
UpdateViewport(preferredZoomLevel);
return;
}
// From -rotate-route mode, or from -rotate-compass if -rotate-route is not allowed, we return to follow mode
if (m_mode == location::FollowAndRotateRoute || m_mode == location::FollowAndRotateCompass)
{ {
if (m_isInRouting && screen.isPerspective()) if (m_isInRouting && screen.isPerspective())
preferredZoomLevel = static_cast<int>(GetZoomLevel(ScreenBase::GetStartPerspectiveScale() * 1.1)); preferredZoomLevel = static_cast<int>(GetZoomLevel(ScreenBase::GetStartPerspectiveScale() * 1.1));
@@ -439,8 +425,8 @@ void MyPositionController::NextMode(ScreenBase const & screen)
} }
} }
void MyPositionController::OnLocationUpdate(location::GpsInfo const & info, void MyPositionController::OnLocationUpdate(location::GpsInfo const & info, bool isNavigable, double distanceToNextTurn,
df::NavigationContext const & navigationContext, ScreenBase const & screen) double speedLimit, ScreenBase const & screen)
{ {
m2::PointD const oldPos = GetDrawablePosition(); m2::PointD const oldPos = GetDrawablePosition();
double const oldAzimut = GetDrawableAzimut(); double const oldAzimut = GetDrawableAzimut();
@@ -452,62 +438,33 @@ void MyPositionController::OnLocationUpdate(location::GpsInfo const & info,
m_errorRadius = rect.SizeX() * 0.5; m_errorRadius = rect.SizeX() * 0.5;
m_horizontalAccuracy = info.m_horizontalAccuracy; m_horizontalAccuracy = info.m_horizontalAccuracy;
if (navigationContext.m_distanceToNextTurn >= 0.0 || navigationContext.m_speedLimit >= 0.0) if (distanceToNextTurn >= 0.0 || speedLimit >= 0.0)
{ {
double const mercatorPerMeter = m_errorRadius / info.m_horizontalAccuracy; double const mercatorPerMeter = m_errorRadius / info.m_horizontalAccuracy;
m_autoScale2d = m_autoScale2d =
mercatorPerMeter * CalculateAutoZoom(navigationContext.m_speedLimit, navigationContext.m_distanceToNextTurn, mercatorPerMeter * CalculateAutoZoom(speedLimit, distanceToNextTurn, false /* isPerspectiveAllowed */);
false /* isPerspectiveAllowed */);
m_autoScale3d = m_autoScale3d =
mercatorPerMeter * CalculateAutoZoom(navigationContext.m_speedLimit, navigationContext.m_distanceToNextTurn, mercatorPerMeter * CalculateAutoZoom(speedLimit, distanceToNextTurn, true /* isPerspectiveAllowed */);
true /* isPerspectiveAllowed */);
} }
else else
{ {
m_autoScale2d = m_autoScale3d = kUnknownAutoZoom; m_autoScale2d = m_autoScale3d = kUnknownAutoZoom;
} }
// Sets arrow direction based on GPS if: // Sets direction based on GPS if:
// 1. Compass is not available. // 1. Compass is not available.
// 2. Direction must be glued to the route during routing (route-corrected angle is set only in // 2. Direction must be glued to the route during routing (route-corrected angle is set only in
// OnLocationUpdate(): in OnCompassUpdate() the angle always has the original value. // OnLocationUpdate(): in OnCompassUpdate() the angle always has the original value.
// 3. Device is moving faster then pedestrian. // 3. Device is moving faster then pedestrian.
bool const isMovingFast = info.HasSpeed() && info.m_speed > kMinSpeedThresholdMps; bool const isMovingFast = info.HasSpeed() && info.m_speed > kMinSpeedThresholdMps;
bool const glueArrowInRouting = navigationContext.m_isNavigable && m_isArrowGluedInRouting; bool const glueArrowInRouting = isNavigable && m_isArrowGluedInRouting;
// Calculate the route direction by looking ahead a distance in the route
// depending on the current speed
if (glueArrowInRouting && navigationContext.m_followedPolyline != nullptr)
{
double const speed =
(navigationContext.m_speedLimit > 0 ? measurement_utils::MpsToKmph(navigationContext.m_speedLimit)
: kDefaultSpeedLimitKmpH);
double const lookaheadTimeSec = std::min(speed * kLookaheadTimeSpeedRatio, kMaxLookaheadTimeSec);
double const lookaheadDistance = std::min(speed * lookaheadTimeSec, navigationContext.m_distanceToNextTurn);
auto const & iter = navigationContext.m_followedPolyline->GetCurrentIter();
m2::PointD const point = navigationContext.m_followedPolyline->GetLookaheadPoint(lookaheadDistance);
auto angle = math::RadToDeg(ang::AngleTo(iter.m_pt, point));
if (std::isnan(angle) || std::isinf(angle))
{
// fallback in case the current route becomes invalid for any reason
SetRouteDirection(info.m_bearing);
}
else
{
SetRouteDirection(math::DegToRad(location::AngleToBearing(angle)));
}
}
if ((!m_isCompassAvailable || glueArrowInRouting || isMovingFast) && info.HasBearing()) if ((!m_isCompassAvailable || glueArrowInRouting || isMovingFast) && info.HasBearing())
{ {
SetArrowDirection(math::DegToRad(info.m_bearing)); SetDirection(math::DegToRad(info.m_bearing));
m_lastGPSBearingTimer.Reset(); m_lastGPSBearingTimer.Reset();
} }
m_direction = m_mode == location::FollowAndRotateRoute ? m_routeDirection : m_arrowDirection;
if (m_isPositionAssigned && (!AlmostCurrentPosition(oldPos) || !AlmostCurrentAzimut(oldAzimut))) if (m_isPositionAssigned && (!AlmostCurrentPosition(oldPos) || !AlmostCurrentAzimut(oldAzimut)))
{ {
CreateAnim(oldPos, oldAzimut, screen); CreateAnim(oldPos, oldAzimut, screen);
@@ -530,9 +487,9 @@ void MyPositionController::OnLocationUpdate(location::GpsInfo const & info,
{ {
ChangeModelView(m_position, kDoNotChangeZoom); ChangeModelView(m_position, kDoNotChangeZoom);
} }
else if (m_mode == location::FollowAndRotateCompass || m_mode == location::FollowAndRotateRoute) else if (m_mode == location::FollowAndRotate)
{ {
ChangeModelView(m_position, m_direction, ChangeModelView(m_position, m_drawDirection,
m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center(), m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center(),
kDoNotChangeZoom); kDoNotChangeZoom);
} }
@@ -542,7 +499,7 @@ void MyPositionController::OnLocationUpdate(location::GpsInfo const & info,
{ {
if (m_isInRouting) if (m_isInRouting)
{ {
ChangeMode(location::FollowAndRotateCompass); ChangeMode(location::FollowAndRotate);
UpdateViewport(kMaxScaleZoomLevel); UpdateViewport(kMaxScaleZoomLevel);
} }
else else
@@ -568,7 +525,7 @@ void MyPositionController::OnLocationUpdate(location::GpsInfo const & info,
{ {
if (m_isInRouting) if (m_isInRouting)
{ {
ChangeMode(location::FollowAndRotateCompass); ChangeMode(location::FollowAndRotate);
UpdateViewport(kMaxScaleZoomLevel); UpdateViewport(kMaxScaleZoomLevel);
} }
else else
@@ -595,8 +552,7 @@ void MyPositionController::LoseLocation()
{ {
if (m_mode == location::NotFollowNoPosition) if (m_mode == location::NotFollowNoPosition)
return; return;
else if (m_mode == location::Follow || m_mode == location::FollowAndRotateCompass || else if (m_mode == location::Follow || m_mode == location::FollowAndRotate)
m_mode == location::FollowAndRotateRoute)
ChangeMode(location::PendingPosition); ChangeMode(location::PendingPosition);
else else
ChangeMode(location::NotFollowNoPosition); ChangeMode(location::NotFollowNoPosition);
@@ -614,11 +570,10 @@ void MyPositionController::OnCompassUpdate(location::CompassInfo const & info, S
if ((IsInRouting() && m_isArrowGluedInRouting) || existsFreshGpsBearing) if ((IsInRouting() && m_isArrowGluedInRouting) || existsFreshGpsBearing)
return; return;
SetArrowDirection(info.m_bearing); SetDirection(info.m_bearing);
if (m_isPositionAssigned && !AlmostCurrentAzimut(oldAzimut) && m_mode == location::FollowAndRotateCompass) if (m_isPositionAssigned && !AlmostCurrentAzimut(oldAzimut) && m_mode == location::FollowAndRotate)
{ {
m_direction = info.m_bearing;
CreateAnim(GetDrawablePosition(), oldAzimut, screen); CreateAnim(GetDrawablePosition(), oldAzimut, screen);
m_isDirtyViewport = true; m_isDirtyViewport = true;
} }
@@ -627,10 +582,10 @@ void MyPositionController::OnCompassUpdate(location::CompassInfo const & info, S
bool MyPositionController::UpdateViewportWithAutoZoom() bool MyPositionController::UpdateViewportWithAutoZoom()
{ {
double const autoScale = m_enablePerspectiveInRouting ? m_autoScale3d : m_autoScale2d; double const autoScale = m_enablePerspectiveInRouting ? m_autoScale3d : m_autoScale2d;
if (autoScale > 0.0 && (m_mode == location::FollowAndRotateCompass || m_mode == location::FollowAndRotateRoute) && if (autoScale > 0.0 && m_mode == location::FollowAndRotate && m_isInRouting && m_enableAutoZoomInRouting &&
m_isInRouting && m_enableAutoZoomInRouting && !m_needBlockAutoZoom) !m_needBlockAutoZoom)
{ {
ChangeModelView(autoScale, m_position, m_direction, GetRoutingRotationPixelCenter()); ChangeModelView(autoScale, m_position, m_drawDirection, GetRoutingRotationPixelCenter());
return true; return true;
} }
return false; return false;
@@ -662,7 +617,7 @@ void MyPositionController::Render(ref_ptr<dp::GraphicsContext> context, ref_ptr<
m_shape->SetPositionObsolete(m_positionIsObsolete); m_shape->SetPositionObsolete(m_positionIsObsolete);
m_shape->SetPosition(m2::PointF(GetDrawablePosition())); m_shape->SetPosition(m2::PointF(GetDrawablePosition()));
m_shape->SetAzimuth(static_cast<float>(GetDrawableAzimut())); m_shape->SetAzimuth(static_cast<float>(GetDrawableAzimut()));
m_shape->SetIsValidAzimuth(IsArrowRotationAvailable()); m_shape->SetIsValidAzimuth(IsRotationAvailable());
m_shape->SetAccuracy(static_cast<float>(m_errorRadius)); m_shape->SetAccuracy(static_cast<float>(m_errorRadius));
m_shape->SetRoutingMode(IsInRouting()); m_shape->SetRoutingMode(IsInRouting());
@@ -676,7 +631,7 @@ void MyPositionController::Render(ref_ptr<dp::GraphicsContext> context, ref_ptr<
bool MyPositionController::IsRouteFollowingActive() const bool MyPositionController::IsRouteFollowingActive() const
{ {
return IsInRouting() && m_mode == location::FollowAndRotateCompass; return IsInRouting() && m_mode == location::FollowAndRotate;
} }
bool MyPositionController::AlmostCurrentPosition(m2::PointD const & pos) const bool MyPositionController::AlmostCurrentPosition(m2::PointD const & pos) const
@@ -688,25 +643,18 @@ bool MyPositionController::AlmostCurrentPosition(m2::PointD const & pos) const
bool MyPositionController::AlmostCurrentAzimut(double azimut) const bool MyPositionController::AlmostCurrentAzimut(double azimut) const
{ {
double constexpr kDirectionEqualityDelta = 1e-3; double constexpr kDirectionEqualityDelta = 1e-3;
return AlmostEqualAbs(azimut, m_direction, kDirectionEqualityDelta); return AlmostEqualAbs(azimut, m_drawDirection, kDirectionEqualityDelta);
} }
void MyPositionController::SetRouteDirection(double bearing) void MyPositionController::SetDirection(double bearing)
{ {
m_routeDirection = bearing; m_drawDirection = bearing;
m_isRouteDirectionAssigned = true; m_isDirectionAssigned = true;
}
void MyPositionController::SetArrowDirection(double bearing)
{
m_arrowDirection = bearing;
m_isArrowDirectionAssigned = true;
} }
void MyPositionController::ChangeMode(location::EMyPositionMode newMode) void MyPositionController::ChangeMode(location::EMyPositionMode newMode)
{ {
if (m_isInRouting && (m_mode != newMode) && if (m_isInRouting && (m_mode != newMode) && (newMode == location::FollowAndRotate))
(newMode == location::FollowAndRotateCompass || newMode == location::FollowAndRotateRoute))
ResetBlockAutoZoomTimer(); ResetBlockAutoZoomTimer();
m_mode = newMode; m_mode = newMode;
@@ -727,8 +675,7 @@ bool MyPositionController::IsWaitingForLocation() const
void MyPositionController::StopLocationFollow() void MyPositionController::StopLocationFollow()
{ {
if (m_mode == location::Follow || m_mode == location::FollowAndRotateCompass || if (m_mode == location::Follow || m_mode == location::FollowAndRotate)
m_mode == location::FollowAndRotateRoute)
ChangeMode(location::NotFollow); ChangeMode(location::NotFollow);
m_desiredInitMode = location::NotFollow; m_desiredInitMode = location::NotFollow;
@@ -743,7 +690,7 @@ void MyPositionController::OnEnterForeground(double backgroundTime)
// When location was active during previous session the app will try to follow the user. // When location was active during previous session the app will try to follow the user.
if (m_mode == location::NotFollow) if (m_mode == location::NotFollow)
{ {
ChangeMode(m_isInRouting ? location::FollowAndRotateCompass : location::Follow); ChangeMode(m_isInRouting ? location::FollowAndRotate : location::Follow);
UpdateViewport(kDoNotChangeZoom); UpdateViewport(kDoNotChangeZoom);
} }
@@ -759,7 +706,7 @@ void MyPositionController::OnEnterBackground() {}
void MyPositionController::OnCompassTapped() void MyPositionController::OnCompassTapped()
{ {
if (m_mode == location::FollowAndRotateCompass) if (m_mode == location::FollowAndRotate)
{ {
ChangeMode(location::Follow); ChangeMode(location::Follow);
ChangeModelView(m_position, 0.0, m_visiblePixelRect.Center(), kDoNotChangeZoom); ChangeModelView(m_position, 0.0, m_visiblePixelRect.Center(), kDoNotChangeZoom);
@@ -816,9 +763,9 @@ void MyPositionController::UpdateViewport(int zoomLevel)
{ {
ChangeModelView(m_position, zoomLevel); ChangeModelView(m_position, zoomLevel);
} }
else if (m_mode == location::FollowAndRotateCompass || m_mode == location::FollowAndRotateRoute) else if (m_mode == location::FollowAndRotate)
{ {
ChangeModelView(m_position, m_direction, ChangeModelView(m_position, m_drawDirection,
m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center(), zoomLevel); m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center(), zoomLevel);
} }
} }
@@ -828,7 +775,7 @@ m2::PointD MyPositionController::GetRotationPixelCenter() const
if (m_mode == location::Follow) if (m_mode == location::Follow)
return m_visiblePixelRect.Center(); return m_visiblePixelRect.Center();
if (m_mode == location::FollowAndRotateCompass || m_mode == location::FollowAndRotateRoute) if (m_mode == location::FollowAndRotate)
return m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center(); return m_isInRouting ? GetRoutingRotationPixelCenter() : m_visiblePixelRect.Center();
return m2::PointD::Zero(); return m2::PointD::Zero();
@@ -870,15 +817,15 @@ double MyPositionController::GetDrawableAzimut()
} }
if (m_isPendingAnimation) if (m_isPendingAnimation)
return m_oldArrowDirection; return m_oldDrawDirection;
return m_arrowDirection; return m_drawDirection;
} }
void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimut, ScreenBase const & screen) void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimut, ScreenBase const & screen)
{ {
double const moveDuration = PositionInterpolator::GetMoveDuration(oldPos, m_position, screen); double const moveDuration = PositionInterpolator::GetMoveDuration(oldPos, m_position, screen);
double const rotateDuration = AngleInterpolator::GetRotateDuration(oldAzimut, m_arrowDirection); double const rotateDuration = AngleInterpolator::GetRotateDuration(oldAzimut, m_drawDirection);
if (df::IsAnimationAllowed(std::max(moveDuration, rotateDuration), screen)) if (df::IsAnimationAllowed(std::max(moveDuration, rotateDuration), screen))
{ {
if (IsModeChangeViewport()) if (IsModeChangeViewport())
@@ -887,7 +834,7 @@ void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimu
{ {
drape_ptr<Animation> anim = make_unique_dp<ArrowAnimation>( drape_ptr<Animation> anim = make_unique_dp<ArrowAnimation>(
GetDrawablePosition(), m_position, syncAnim == nullptr ? moveDuration : syncAnim->GetDuration(), GetDrawablePosition(), m_position, syncAnim == nullptr ? moveDuration : syncAnim->GetDuration(),
GetDrawableAzimut(), m_arrowDirection); GetDrawableAzimut(), m_drawDirection);
if (syncAnim != nullptr) if (syncAnim != nullptr)
{ {
anim->SetMaxDuration(syncAnim->GetMaxDuration()); anim->SetMaxDuration(syncAnim->GetMaxDuration());
@@ -896,13 +843,13 @@ void MyPositionController::CreateAnim(m2::PointD const & oldPos, double oldAzimu
return anim; return anim;
}; };
m_oldPosition = oldPos; m_oldPosition = oldPos;
m_oldArrowDirection = oldAzimut; m_oldDrawDirection = oldAzimut;
m_isPendingAnimation = true; m_isPendingAnimation = true;
} }
else else
{ {
AnimationSystem::Instance().CombineAnimation( AnimationSystem::Instance().CombineAnimation(
make_unique_dp<ArrowAnimation>(oldPos, m_position, moveDuration, oldAzimut, m_arrowDirection)); make_unique_dp<ArrowAnimation>(oldPos, m_position, moveDuration, oldAzimut, m_drawDirection));
} }
} }
} }
@@ -921,18 +868,16 @@ void MyPositionController::EnableAutoZoomInRouting(bool enableAutoZoom)
} }
} }
void MyPositionController::ActivateRouting(int zoomLevel, bool enableAutoZoom, bool isArrowGlued, void MyPositionController::ActivateRouting(int zoomLevel, bool enableAutoZoom, bool isArrowGlued)
bool allowRouteRotation)
{ {
if (!m_isInRouting) if (!m_isInRouting)
{ {
m_isInRouting = true; m_isInRouting = true;
m_isArrowGluedInRouting = isArrowGlued; m_isArrowGluedInRouting = isArrowGlued;
m_enableAutoZoomInRouting = enableAutoZoom; m_enableAutoZoomInRouting = enableAutoZoom;
m_allowRouteRotationInRouting = allowRouteRotation;
ChangeMode(location::FollowAndRotateCompass); ChangeMode(location::FollowAndRotate);
ChangeModelView(m_position, m_isRouteDirectionAssigned ? m_routeDirection : 0.0, GetRoutingRotationPixelCenter(), ChangeModelView(m_position, m_isDirectionAssigned ? m_drawDirection : 0.0, GetRoutingRotationPixelCenter(),
zoomLevel, [this](ref_ptr<Animation> anim) { UpdateViewport(kDoNotChangeZoom); }); zoomLevel, [this](ref_ptr<Animation> anim) { UpdateViewport(kDoNotChangeZoom); });
ResetRoutingNotFollowTimer(); ResetRoutingNotFollowTimer();
} }
@@ -944,10 +889,8 @@ void MyPositionController::DeactivateRouting()
{ {
m_isInRouting = false; m_isInRouting = false;
m_isArrowGluedInRouting = false; m_isArrowGluedInRouting = false;
m_allowRouteRotationInRouting = false;
m_isArrowDirectionAssigned = m_isCompassAvailable && m_isArrowDirectionAssigned; m_isDirectionAssigned = m_isCompassAvailable && m_isDirectionAssigned;
m_isRouteDirectionAssigned = false;
ChangeMode(location::Follow); ChangeMode(location::Follow);
ChangeModelView(m_position, 0.0, m_visiblePixelRect.Center(), kDoNotChangeZoom); ChangeModelView(m_position, 0.0, m_visiblePixelRect.Center(), kDoNotChangeZoom);
@@ -976,7 +919,7 @@ void MyPositionController::CheckNotFollowRouting()
CHECK_ON_TIMEOUT(m_routingNotFollowNotifyId, kMaxNotFollowRoutingTimeSec, CheckNotFollowRouting); CHECK_ON_TIMEOUT(m_routingNotFollowNotifyId, kMaxNotFollowRoutingTimeSec, CheckNotFollowRouting);
if (m_routingNotFollowTimer.ElapsedSeconds() >= kMaxNotFollowRoutingTimeSec) if (m_routingNotFollowTimer.ElapsedSeconds() >= kMaxNotFollowRoutingTimeSec)
{ {
ChangeMode(location::FollowAndRotateCompass); ChangeMode(location::FollowAndRotate);
UpdateViewport(kDoNotChangeZoom); UpdateViewport(kDoNotChangeZoom);
} }
} }

View File

@@ -7,7 +7,6 @@
#include "drape/pointers.hpp" #include "drape/pointers.hpp"
#include "routing/base/followed_polyline.hpp"
#include "shaders/program_manager.hpp" #include "shaders/program_manager.hpp"
#include "platform/location.hpp" #include "platform/location.hpp"
@@ -25,24 +24,6 @@ using TAnimationCreator = std::function<drape_ptr<Animation>(ref_ptr<Animation>)
class DrapeNotifier; class DrapeNotifier;
struct NavigationContext
{
bool m_isNavigable = false;
double m_distanceToNextTurn = 0.0;
double m_speedLimit = 0.0;
routing::FollowedPolyline const * m_followedPolyline = nullptr;
NavigationContext() = default;
NavigationContext(bool navigable, double distanceToTurn, double speedLimit,
routing::FollowedPolyline const & followedPolyline)
: m_isNavigable(navigable)
, m_distanceToNextTurn(distanceToTurn)
, m_speedLimit(speedLimit)
, m_followedPolyline(&followedPolyline)
{}
};
class MyPositionController class MyPositionController
{ {
public: public:
@@ -121,7 +102,7 @@ public:
drape_ptr<MyPosition> && shape, Arrow3d::PreloadedData && preloadedData); drape_ptr<MyPosition> && shape, Arrow3d::PreloadedData && preloadedData);
void ResetRenderShape(); void ResetRenderShape();
void ActivateRouting(int zoomLevel, bool enableAutoZoom, bool isArrowGlued, bool allowRouteRotation); void ActivateRouting(int zoomLevel, bool enableAutoZoom, bool isArrowGlued);
void DeactivateRouting(); void DeactivateRouting();
void EnablePerspectiveInRouting(bool enablePerspective); void EnablePerspectiveInRouting(bool enablePerspective);
@@ -136,15 +117,14 @@ public:
void OnEnterBackground(); void OnEnterBackground();
void OnCompassTapped(); void OnCompassTapped();
void OnLocationUpdate(location::GpsInfo const & info, df::NavigationContext const & navigationContext, void OnLocationUpdate(location::GpsInfo const & info, bool isNavigable, double distanceToNextTurn, double speedLimit,
ScreenBase const & screen); ScreenBase const & screen);
void OnCompassUpdate(location::CompassInfo const & info, ScreenBase const & screen); void OnCompassUpdate(location::CompassInfo const & info, ScreenBase const & screen);
void Render(ref_ptr<dp::GraphicsContext> context, ref_ptr<gpu::ProgramManager> mng, ScreenBase const & screen, void Render(ref_ptr<dp::GraphicsContext> context, ref_ptr<gpu::ProgramManager> mng, ScreenBase const & screen,
int zoomLevel, FrameValues const & frameValues); int zoomLevel, FrameValues const & frameValues);
bool IsArrowRotationAvailable() const { return m_isArrowDirectionAssigned; } bool IsRotationAvailable() const { return m_isDirectionAssigned; }
bool IsRouteRotationAvailable() const { return m_isRouteDirectionAssigned; }
bool IsInRouting() const { return m_isInRouting; } bool IsInRouting() const { return m_isInRouting; }
bool IsRouteFollowingActive() const; bool IsRouteFollowingActive() const;
bool IsModeChangeViewport() const; bool IsModeChangeViewport() const;
@@ -155,8 +135,7 @@ public:
private: private:
void ChangeMode(location::EMyPositionMode newMode); void ChangeMode(location::EMyPositionMode newMode);
void SetRouteDirection(double bearing); void SetDirection(double bearing);
void SetArrowDirection(double bearing);
void ChangeModelView(m2::PointD const & center, int zoomLevel); void ChangeModelView(m2::PointD const & center, int zoomLevel);
void ChangeModelView(double azimuth); void ChangeModelView(double azimuth);
@@ -199,15 +178,12 @@ private:
double m_errorRadius; // error radius in mercator. double m_errorRadius; // error radius in mercator.
double m_horizontalAccuracy; double m_horizontalAccuracy;
m2::PointD m_position; // position in mercator. m2::PointD m_position; // position in mercator.
double m_direction; double m_drawDirection;
double m_routeDirection;
double m_arrowDirection;
m2::PointD m_oldPosition; // position in mercator. m2::PointD m_oldPosition; // position in mercator.
double m_oldArrowDirection; double m_oldDrawDirection;
bool m_enablePerspectiveInRouting; bool m_enablePerspectiveInRouting;
bool m_enableAutoZoomInRouting; bool m_enableAutoZoomInRouting;
bool m_allowRouteRotationInRouting;
double m_autoScale2d; double m_autoScale2d;
double m_autoScale3d; double m_autoScale3d;
@@ -229,8 +205,7 @@ private:
TAnimationCreator m_animCreator; TAnimationCreator m_animCreator;
bool m_isPositionAssigned; bool m_isPositionAssigned;
bool m_isArrowDirectionAssigned; bool m_isDirectionAssigned;
bool m_isRouteDirectionAssigned;
bool m_isCompassAvailable; bool m_isCompassAvailable;
bool m_positionIsObsolete; bool m_positionIsObsolete;

View File

@@ -31,8 +31,8 @@ namespace df
{ {
namespace namespace
{ {
uint64_t constexpr kDoubleTapPauseMs = 200; uint64_t constexpr kDoubleTapPauseMs = 250;
uint64_t constexpr kLongTouchMs = 700; uint64_t constexpr kLongTouchMs = 500;
uint64_t constexpr kKineticDelayMs = 500; uint64_t constexpr kKineticDelayMs = 500;
float constexpr kForceTapThreshold = 0.75; float constexpr kForceTapThreshold = 0.75;

View File

@@ -507,16 +507,16 @@ private:
// Implementations of "ref" parses for some countries. // Implementations of "ref" parses for some countries.
class AustriaRoadShieldParser : public SimpleRoadShieldParser class AustriaRoadShieldParser : public HighwayClassRoadShieldParser
{ {
public: public:
explicit AustriaRoadShieldParser(std::string const & baseRoadNumber) explicit AustriaRoadShieldParser(std::string const & baseRoadNumber, HighwayClass const & highwayClass)
: SimpleRoadShieldParser(baseRoadNumber, : HighwayClassRoadShieldParser(baseRoadNumber, highwayClass,
{{"A", RoadShieldType::Generic_Blue_Bordered}, {{"A", HighwayClass::Motorway, RoadShieldType::Generic_Blue_Bordered},
{"S", RoadShieldType::Generic_Blue_Bordered}, {"S", HighwayClass::Trunk, RoadShieldType::Generic_Blue_Bordered},
{"B", RoadShieldType::Generic_Blue, false, true}, {"B", HighwayClass::Primary, RoadShieldType::Generic_Blue},
{"P", RoadShieldType::Generic_Pill_Red, false, true}, {"L", HighwayClass::Secondary, RoadShieldType::Generic_Pill_White_Bordered},
{"L", RoadShieldType::Generic_Pill_White_Bordered, false, true}}) {"L", HighwayClass::Tertiary, RoadShieldType::Generic_Pill_White_Bordered}})
{} {}
}; };
@@ -554,9 +554,9 @@ class ItalyRoadShieldParser : public SimpleRoadShieldParser
public: public:
explicit ItalyRoadShieldParser(std::string const & baseRoadNumber) explicit ItalyRoadShieldParser(std::string const & baseRoadNumber)
: SimpleRoadShieldParser(baseRoadNumber, {{"A", RoadShieldType::Italy_Autostrada}, : SimpleRoadShieldParser(baseRoadNumber, {{"A", RoadShieldType::Italy_Autostrada},
{"SS", RoadShieldType::Generic_Blue_Bordered}, {"SS", RoadShieldType::Generic_Blue},
{"SR", RoadShieldType::Generic_Blue_Bordered}, {"SR", RoadShieldType::Generic_Blue},
{"SP", RoadShieldType::Generic_Blue_Bordered}}) {"SP", RoadShieldType::Generic_Blue}})
{} {}
}; };
@@ -601,24 +601,11 @@ public:
{"N", RoadShieldType::Generic_White_Bordered}, {"N", RoadShieldType::Generic_White_Bordered},
{"EN", RoadShieldType::Generic_White_Bordered}, {"EN", RoadShieldType::Generic_White_Bordered},
{"R", RoadShieldType::Generic_Orange}, {"R", RoadShieldType::Generic_Orange},
{"IP", RoadShieldType::Generic_Red},
{"IC", RoadShieldType::Generic_White_Bordered},
{"EM", RoadShieldType::Generic_Orange}, {"EM", RoadShieldType::Generic_Orange},
{"CM", RoadShieldType::Generic_Orange}}) {"CM", RoadShieldType::Generic_Orange}})
{} {}
}; };
class AlbaniaRoadShieldParser : public SimpleRoadShieldParser
{
public:
explicit AlbaniaRoadShieldParser(std::string const & baseRoadNumber)
: SimpleRoadShieldParser(baseRoadNumber, {{"A", RoadShieldType::Italy_Autostrada},
{"SH", RoadShieldType::Generic_Blue_Bordered},
{"RR", RoadShieldType::Generic_Blue_Bordered},
{"E", RoadShieldType::Generic_Green_Bordered}})
{}
};
class RomaniaRoadShieldParser : public SimpleRoadShieldParser class RomaniaRoadShieldParser : public SimpleRoadShieldParser
{ {
public: public:
@@ -711,16 +698,17 @@ public:
{} {}
}; };
class GermanyRoadShieldParser : public SimpleRoadShieldParser class GermanyRoadShieldParser : public HighwayClassRoadShieldParser
{ {
public: public:
explicit GermanyRoadShieldParser(std::string const & baseRoadNumber) explicit GermanyRoadShieldParser(std::string const & baseRoadNumber, HighwayClass const & highwayClass)
: SimpleRoadShieldParser(baseRoadNumber, : HighwayClassRoadShieldParser(baseRoadNumber, highwayClass,
{{"A", RoadShieldType::Highway_Hexagon_Blue, false, true}, {{"A", HighwayClass::Motorway, RoadShieldType::Highway_Hexagon_Blue, false, true},
{"D", RoadShieldType::Hidden}, {"D", HighwayClass::Motorway, RoadShieldType::Hidden},
{"B", RoadShieldType::Generic_Orange_Bordered}, {"B", HighwayClass::Trunk, RoadShieldType::Generic_Orange_Bordered},
{"K", RoadShieldType::Generic_White_Bordered}, {"B", HighwayClass::Primary, RoadShieldType::Generic_Orange_Bordered},
{"L", RoadShieldType::Generic_White_Bordered}}) {"L", HighwayClass::Secondary, RoadShieldType::Generic_White_Bordered},
{"K", HighwayClass::Secondary, RoadShieldType::Generic_White_Bordered}})
{} {}
}; };
@@ -913,8 +901,6 @@ RoadShieldsSetT GetRoadShields(std::string const & mwmName, std::string const &
return MoldovaRoadShieldParser(roadNumber).GetRoadShields(); return MoldovaRoadShieldParser(roadNumber).GetRoadShields();
if (mwmName == "Portugal") if (mwmName == "Portugal")
return PortugalRoadShieldParser(roadNumber).GetRoadShields(); return PortugalRoadShieldParser(roadNumber).GetRoadShields();
if (mwmName == "Albania")
return AlbaniaRoadShieldParser(roadNumber).GetRoadShields();
if (mwmName == "Romania") if (mwmName == "Romania")
return RomaniaRoadShieldParser(roadNumber).GetRoadShields(); return RomaniaRoadShieldParser(roadNumber).GetRoadShields();
if (mwmName == "Serbia") if (mwmName == "Serbia")

View File

@@ -7,7 +7,6 @@
#include "ge0/url_generator.hpp" #include "ge0/url_generator.hpp"
#include "platform/location.hpp"
#include "routing/route.hpp" #include "routing/route.hpp"
#include "routing/speed_camera_prohibition.hpp" #include "routing/speed_camera_prohibition.hpp"
@@ -1454,7 +1453,7 @@ void Framework::CreateDrapeEngine(ref_ptr<dp::GraphicsContextFactory> contextFac
GetPlatform().RunTask(Platform::Thread::Gui, [this, mode, routingActive]() GetPlatform().RunTask(Platform::Thread::Gui, [this, mode, routingActive]()
{ {
// Deactivate selection (and hide place page) if we return to routing in F&R mode. // Deactivate selection (and hide place page) if we return to routing in F&R mode.
if (routingActive && (mode == location::FollowAndRotateCompass || mode == location::FollowAndRotateRoute)) if (routingActive && mode == location::FollowAndRotate)
DeactivateMapSelection(); DeactivateMapSelection();
if (m_myPositionListener != nullptr) if (m_myPositionListener != nullptr)
@@ -3209,7 +3208,6 @@ void Framework::ReadFeatures(function<void(FeatureType &)> const & reader, vecto
void Framework::OnRouteFollow(routing::RouterType type) void Framework::OnRouteFollow(routing::RouterType type)
{ {
bool const isPedestrianRoute = type == RouterType::Pedestrian; bool const isPedestrianRoute = type == RouterType::Pedestrian;
bool const allowRouteRotation = type == RouterType::Vehicle;
bool const enableAutoZoom = isPedestrianRoute ? false : LoadAutoZoom(); bool const enableAutoZoom = isPedestrianRoute ? false : LoadAutoZoom();
int const scale = isPedestrianRoute ? scales::GetPedestrianNavigationScale() : scales::GetNavigationScale(); int const scale = isPedestrianRoute ? scales::GetPedestrianNavigationScale() : scales::GetNavigationScale();
int scale3d = isPedestrianRoute ? scales::GetPedestrianNavigation3dScale() : scales::GetNavigation3dScale(); int scale3d = isPedestrianRoute ? scales::GetPedestrianNavigation3dScale() : scales::GetNavigation3dScale();
@@ -3225,7 +3223,7 @@ void Framework::OnRouteFollow(routing::RouterType type)
// TODO. We need to sync two enums VehicleType and RouterType to be able to pass // TODO. We need to sync two enums VehicleType and RouterType to be able to pass
// GetRoutingSettings(type).m_matchRoute to the FollowRoute() instead of |isPedestrianRoute|. // GetRoutingSettings(type).m_matchRoute to the FollowRoute() instead of |isPedestrianRoute|.
// |isArrowGlued| parameter fully corresponds to |m_matchRoute| in RoutingSettings. // |isArrowGlued| parameter fully corresponds to |m_matchRoute| in RoutingSettings.
m_drapeEngine->FollowRoute(scale, scale3d, enableAutoZoom, !isPedestrianRoute /* isArrowGlued */, allowRouteRotation); m_drapeEngine->FollowRoute(scale, scale3d, enableAutoZoom, !isPedestrianRoute /* isArrowGlued */);
} }
// RoutingManager::Delegate // RoutingManager::Delegate

View File

@@ -1,12 +1,9 @@
#include "routing_manager.hpp" #include "routing_manager.hpp"
#include "drape_frontend/my_position_controller.hpp"
#include "geometry/angles.hpp"
#include "map/chart_generator.hpp" #include "map/chart_generator.hpp"
#include "map/routing_mark.hpp" #include "map/routing_mark.hpp"
#include "routing/absent_regions_finder.hpp" #include "routing/absent_regions_finder.hpp"
#include "routing/base/followed_polyline.hpp"
#include "routing/checkpoint_predictor.hpp" #include "routing/checkpoint_predictor.hpp"
#include "routing/index_router.hpp" #include "routing/index_router.hpp"
#include "routing/route.hpp" #include "routing/route.hpp"
@@ -1173,9 +1170,9 @@ void RoutingManager::SetDrapeEngine(ref_ptr<df::DrapeEngine> engine, bool is3dAl
if (m_gpsInfoCache != nullptr) if (m_gpsInfoCache != nullptr)
{ {
auto routeMatchingInfo = GetRouteMatchingInfo(*m_gpsInfoCache); auto routeMatchingInfo = GetRouteMatchingInfo(*m_gpsInfoCache);
df::NavigationContext navigationContext(m_routingSession.IsNavigable(), m_routingSession.GetDistanceToNextTurn(), m_drapeEngine.SafeCall(&df::DrapeEngine::SetGpsInfo, *m_gpsInfoCache, m_routingSession.IsNavigable(),
m_routingSession.GetCurrentSpeedLimit(), GetRoutePolyline()); m_routingSession.GetDistanceToNextTurn(), m_routingSession.GetCurrentSpeedLimit(),
m_drapeEngine.SafeCall(&df::DrapeEngine::SetGpsInfo, *m_gpsInfoCache, navigationContext, routeMatchingInfo); routeMatchingInfo);
m_gpsInfoCache.reset(); m_gpsInfoCache.reset();
} }
@@ -1519,9 +1516,9 @@ void RoutingManager::OnExtrapolatedLocationUpdate(location::GpsInfo const & info
m_gpsInfoCache = make_unique<location::GpsInfo>(gpsInfo); m_gpsInfoCache = make_unique<location::GpsInfo>(gpsInfo);
auto routeMatchingInfo = GetRouteMatchingInfo(gpsInfo); auto routeMatchingInfo = GetRouteMatchingInfo(gpsInfo);
df::NavigationContext navigationContext(m_routingSession.IsNavigable(), m_routingSession.GetDistanceToNextTurn(), m_drapeEngine.SafeCall(&df::DrapeEngine::SetGpsInfo, gpsInfo, m_routingSession.IsNavigable(),
m_routingSession.GetCurrentSpeedLimit(), GetRoutePolyline()); m_routingSession.GetDistanceToNextTurn(), m_routingSession.GetCurrentSpeedLimit(),
m_drapeEngine.SafeCall(&df::DrapeEngine::SetGpsInfo, gpsInfo, navigationContext, routeMatchingInfo); routeMatchingInfo);
} }
void RoutingManager::DeleteSavedRoutePoints() void RoutingManager::DeleteSavedRoutePoints()

View File

@@ -27,7 +27,7 @@ namespace routing::turns::sound
* - All other variants default to `zh-Hans` (Simplified Chinese). * - All other variants default to `zh-Hans` (Simplified Chinese).
* *
*/ */
std::array<std::pair<std::string_view, std::string_view>, 43> constexpr kLanguageList = {{ std::array<std::pair<std::string_view, std::string_view>, 42> constexpr kLanguageList = {{
{"en", "English"}, {"en", "English"},
{"id", "Bahasa Indonesia"}, {"id", "Bahasa Indonesia"},
{"ca", "Català"}, {"ca", "Català"},
@@ -82,6 +82,5 @@ std::array<std::pair<std::string_view, std::string_view>, 43> constexpr kLanguag
#endif #endif
{"ja", "日本語"}, {"ja", "日本語"},
{"ko", "한국어"}, {"ko", "한국어"},
{"ta", "தமிழ்"},
}}; }};
} // namespace routing::turns::sound } // namespace routing::turns::sound

View File

@@ -139,8 +139,7 @@ enum EMyPositionMode
NotFollowNoPosition, NotFollowNoPosition,
NotFollow, NotFollow,
Follow, Follow,
FollowAndRotateCompass, FollowAndRotate
FollowAndRotateRoute
}; };
using TMyPositionModeChanged = std::function<void(location::EMyPositionMode, bool)>; using TMyPositionModeChanged = std::function<void(location::EMyPositionMode, bool)>;

View File

@@ -308,8 +308,7 @@ string ToString<location::EMyPositionMode>(location::EMyPositionMode const & v)
case location::NotFollow: return "NotFollow"; case location::NotFollow: return "NotFollow";
case location::NotFollowNoPosition: return "NotFollowNoPosition"; case location::NotFollowNoPosition: return "NotFollowNoPosition";
case location::Follow: return "Follow"; case location::Follow: return "Follow";
case location::FollowAndRotateCompass: return "FollowAndRotateCompass"; case location::FollowAndRotate: return "FollowAndRotate";
case location::FollowAndRotateRoute: return "FollowAndRotateRoute";
default: return "Pending"; default: return "Pending";
} }
} }
@@ -325,10 +324,8 @@ bool FromString<location::EMyPositionMode>(string const & s, location::EMyPositi
v = location::NotFollowNoPosition; v = location::NotFollowNoPosition;
else if (s == "Follow") else if (s == "Follow")
v = location::Follow; v = location::Follow;
else if (s == "FollowAndRotateCompass") else if (s == "FollowAndRotate")
v = location::FollowAndRotateCompass; v = location::FollowAndRotate;
else if (s == "FollowAndRotateRoute")
v = location::FollowAndRotateRoute;
else else
return false; return false;

View File

@@ -237,34 +237,4 @@ Iter FollowedPolyline::GetClosestMatchingProjectionInInterval(m2::RectD const &
return nearestIter; return nearestIter;
} }
m2::PointD FollowedPolyline::GetLookaheadPoint(double lookaheadDistanceM) const
{
if (!IsValid())
return m2::PointD();
size_t segmentIdx = m_current.m_ind;
m2::PointD prev = m_current.m_pt;
size_t const maxSegmentIdx = m_poly.GetSize() - 1;
double remaining = lookaheadDistanceM;
while (segmentIdx < maxSegmentIdx)
{
m2::PointD const & next = m_poly.GetPoint(segmentIdx + 1);
double segLen = mercator::DistanceOnEarth(prev, next);
if (remaining <= segLen)
{
double t = remaining / segLen;
return prev + (next - prev) * t;
}
remaining -= segLen;
prev = next;
segmentIdx += 1;
}
return m_poly.GetPoint(segmentIdx);
}
} // namespace routing } // namespace routing

View File

@@ -125,9 +125,6 @@ public:
bool IsFakeSegment(size_t index) const; bool IsFakeSegment(size_t index) const;
/// \brief Obtain a point |lookaheadDistanceM| meters along the current route
m2::PointD GetLookaheadPoint(double lookaheadDistanceM) const;
private: private:
/// \returns iterator to the best projection of center of |posRect| to the |m_poly|. /// \returns iterator to the best projection of center of |posRect| to the |m_poly|.
/// If there's a good projection of center of |posRect| to two closest segments of |m_poly| /// If there's a good projection of center of |posRect| to two closest segments of |m_poly|