From ef2dea20feface350bc8663937f789b20ff8b907 Mon Sep 17 00:00:00 2001 From: Kiryl Kaveryn Date: Wed, 30 Jul 2025 18:34:43 +0400 Subject: [PATCH] [ios] Log error during the track editing instead of failing The bug is quite rare and happens when the user taps on the edit (pencil) button on the PlacePage. It seems like the tap happens during the PP data object reloading the and the object type has changed. It is better to avoid failing in such cases because we cannot prevent user interaction during the pp reloading. Signed-off-by: Kiryl Kaveryn --- .../UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm b/iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm index a07cbffe2..484c99e9f 100644 --- a/iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm +++ b/iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm @@ -225,9 +225,11 @@ using namespace storage; [[MapViewController sharedController].navigationController pushViewController:editBookmarkController animated:YES]; } -- (void)editTrack:(PlacePageData *)data { - if (data.objectType != PlacePageObjectTypeTrack) { - ASSERT_FAIL("editTrack called for non-track object"); +- (void)editTrack:(PlacePageData *)data +{ + if (data.objectType != PlacePageObjectTypeTrack) + { + LOG(LERROR, ("editTrack called for non-track object")); return; } EditTrackViewController * editTrackController = [[EditTrackViewController alloc] initWithTrackId:data.trackData.trackId editCompletion:^(BOOL edited) {