drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2026-01-04 11:53:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ios] Review fixes

Browse Source 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
This commit is contained in:
Kiryl Kaveryn
2025-06-10 13:34:25 +04:00
committed by Yannik Bloscheck
parent d677112edd
commit e2efbbe68c
10 changed files with 79 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
iphone/Maps/Tests/Core/TrackRecorder/TrackRecordingManagerTests.swift
View File

@@ -51,7 +51,7 @@ final class TrackRecordingManagerTests: XCTestCase {
mockLocationService.locationIsProhibited = false
mockTrackRecorder.trackRecordingIsEnabled = false
trackRecordingManager.processAction(.start)
trackRecordingManager.start()
XCTAssertTrue(mockTrackRecorder.startTrackRecordingCalled)
XCTAssertTrue(mockActivityManager.startCalled)
@@ -60,20 +60,21 @@ final class TrackRecordingManagerTests: XCTestCase {
func test_GivenStartRecording_WhenLocationDisabled_ThenShouldFail() {
mockLocationService.locationIsProhibited = true
trackRecordingManager.processAction(.start) { result in
let expectation = expectation(description: "Location is prohibited")
trackRecordingManager.start() { result in
switch result {
case .success:
XCTFail("Should not succeed")
case .error(let error):
case .failure(let error):
switch error {
case .locationIsProhibited:
XCTAssertTrue(true)
case LocationError.locationIsProhibited:
expectation.fulfill()
default:
XCTFail("Unexpected error: \(error)")
}
}
}
wait(for: [expectation], timeout: 1.0)
XCTAssertFalse(self.mockTrackRecorder.startTrackRecordingCalled)
XCTAssertTrue(trackRecordingManager.recordingState == .inactive)
}
@@ -82,12 +83,12 @@ final class TrackRecordingManagerTests: XCTestCase {
mockTrackRecorder.trackRecordingIsEnabled = true
mockTrackRecorder.trackRecordingIsEmpty = false
trackRecordingManager.processAction(.stopAndSave(name: "Test Track")) { result in
trackRecordingManager.stopAndSave(withName: "Test Track") { result in
switch result {
case .success:
XCTAssertTrue(true)
case .error(let error):
XCTFail("Unexpected error: \(error)")
case .trackIsEmpty:
XCTFail("Track should not be empty")
}
}
XCTAssertTrue(mockTrackRecorder.stopTrackRecordingCalled)
@@ -99,20 +100,16 @@ final class TrackRecordingManagerTests: XCTestCase {
func test_GivenStopRecording_WhenTrackIsEmpty_ThenShouldFail() {
mockTrackRecorder.trackRecordingIsEnabled = true
mockTrackRecorder.trackRecordingIsEmpty = true
trackRecordingManager.processAction(.stopAndSave(name: "Test Track")) { result in
let expectation = expectation(description: "Track recording should be empty")
trackRecordingManager.stopAndSave(withName: "Test Track") { result in
switch result {
case .success:
XCTFail("Should not succeed")
case .error(let error):
switch error {
case .trackIsEmpty:
XCTAssertTrue(true)
default:
XCTFail("Unexpected error: \(error)")
}
case .trackIsEmpty:
expectation.fulfill()
}
}
wait(for: [expectation], timeout: 1.0)
XCTAssertFalse(mockTrackRecorder.saveTrackRecordingCalled)
XCTAssertTrue(trackRecordingManager.recordingState == .inactive)
}