From ca5cc46f2b2e97f2838acaf98e9742d905fe3c48 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Date: Sun, 24 Aug 2025 17:48:33 +0200 Subject: [PATCH] [android] Migrate Primary buttons to Material 3 themes Signed-off-by: Jean-Baptiste --- .../routing/ManageRouteBottomSheet.java | 6 +++--- .../routing/RoutingBottomMenuController.java | 6 +++--- android/app/src/main/res/layout-land/about.xml | 8 ++++---- .../res/layout-land/altitude_chart_panel.xml | 12 +++++++----- .../res/layout-land/fragment_osm_login.xml | 12 +++++------- .../main/res/layout-land/onmap_downloader.xml | 2 +- .../altitude_chart_panel.xml | 12 +++++++----- android/app/src/main/res/layout/about.xml | 10 +++++----- .../res/layout/activity_map_placeholder.xml | 2 +- .../layout/activity_request_permissions.xml | 2 +- .../main/res/layout/altitude_chart_panel.xml | 12 +++++++----- .../main/res/layout/button_with_progress.xml | 2 +- .../src/main/res/layout/fragment_osm_login.xml | 18 +++++++++--------- .../fragment_suggest_country_download.xml | 4 ++-- .../layout/item_feature_category_footer.xml | 10 ++++++---- .../src/main/res/layout/item_timetable_add.xml | 7 +++++-- .../res/layout/manage_route_bottom_sheet.xml | 11 ++++++----- .../src/main/res/layout/onmap_downloader.xml | 2 +- .../app/src/main/res/layout/start_button.xml | 4 ++-- android/app/src/main/res/values/styles.xml | 14 ++++++++++++++ 20 files changed, 90 insertions(+), 66 deletions(-) diff --git a/android/app/src/main/java/app/organicmaps/routing/ManageRouteBottomSheet.java b/android/app/src/main/java/app/organicmaps/routing/ManageRouteBottomSheet.java index 8e7349a04..5f3336033 100644 --- a/android/app/src/main/java/app/organicmaps/routing/ManageRouteBottomSheet.java +++ b/android/app/src/main/java/app/organicmaps/routing/ManageRouteBottomSheet.java @@ -9,7 +9,6 @@ import android.view.KeyEvent; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -import android.widget.Button; import android.widget.FrameLayout; import android.widget.ImageView; import androidx.annotation.NonNull; @@ -27,6 +26,7 @@ import app.organicmaps.util.UiUtils; import com.google.android.material.bottomsheet.BottomSheetBehavior; import com.google.android.material.bottomsheet.BottomSheetDialog; import com.google.android.material.bottomsheet.BottomSheetDialogFragment; +import com.google.android.material.button.MaterialButton; import com.google.android.material.divider.MaterialDividerItemDecoration; import java.util.ArrayList; @@ -42,10 +42,10 @@ public class ManageRouteBottomSheet { View v = inflater.inflate(R.layout.manage_route_bottom_sheet, container, false); - Button cancelButton = v.findViewById(R.id.btn__cancel); + MaterialButton cancelButton = v.findViewById(R.id.btn__cancel); cancelButton.setOnClickListener(this); - Button planButton = v.findViewById(R.id.btn__plan); + MaterialButton planButton = v.findViewById(R.id.btn__plan); planButton.setOnClickListener(this); mMyLocationImageView = v.findViewById(R.id.image_my_location); diff --git a/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java b/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java index a9de92638..aa60c4de7 100644 --- a/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java +++ b/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java @@ -68,7 +68,7 @@ final class RoutingBottomMenuController implements View.OnClickListener @NonNull private final MaterialTextView mError; @NonNull - private final Button mStart; + private final MaterialButton mStart; @NonNull private final ImageView mAltitudeChart; @NonNull @@ -101,7 +101,7 @@ final class RoutingBottomMenuController implements View.OnClickListener View timeElevationLine = getViewById(activity, frame, R.id.time_elevation_line); View transitFrame = getViewById(activity, frame, R.id.transit_panel); MaterialTextView error = (MaterialTextView) getViewById(activity, frame, R.id.error); - Button start = (Button) getViewById(activity, frame, R.id.start); + MaterialButton start = (MaterialButton) getViewById(activity, frame, R.id.start); ImageView altitudeChart = (ImageView) getViewById(activity, frame, R.id.altitude_chart); MaterialTextView time = (MaterialTextView) getViewById(activity, frame, R.id.time); TextView timeVehicle = (TextView) getViewById(activity, frame, R.id.time_vehicle); @@ -123,7 +123,7 @@ final class RoutingBottomMenuController implements View.OnClickListener private RoutingBottomMenuController(@NonNull Activity context, @NonNull View altitudeChartFrame, @NonNull View timeElevationLine, @NonNull View transitFrame, - @NonNull MaterialTextView error, @NonNull Button start, + @NonNull MaterialTextView error, @NonNull MaterialButton start, @NonNull ImageView altitudeChart, @NonNull MaterialTextView time, @NonNull MaterialTextView altitudeDifference, @NonNull TextView timeVehicle, @Nullable MaterialTextView arrival, @NonNull View actionFrame, diff --git a/android/app/src/main/res/layout-land/about.xml b/android/app/src/main/res/layout-land/about.xml index 9f2e4fd3b..15bc5be4f 100644 --- a/android/app/src/main/res/layout-land/about.xml +++ b/android/app/src/main/res/layout-land/about.xml @@ -166,7 +166,7 @@ android:orientation="horizontal"> + app:layout_constraintVertical_bias="0.5" + app:backgroundTint="@color/light_gray"/> @@ -84,13 +85,14 @@ android:layout_gravity="center_vertical" android:layout_marginStart="@dimen/margin_base" android:minHeight="@dimen/primary_button_min_height" - style="@style/MwmWidget.Button" + style="@style/Widget.Material3.Button.TextButton" android:text="@string/save" - android:textColor="?android:textColorPrimary"/> + android:textColor="?android:textColorPrimary" + android:textAppearance="@style/MwmTextAppearance.Body1"/> -