[android] Fix warnings

Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>

android/app/src/main/java/app/organicmaps/SplashActivity.java

@@ -4,7 +4,6 @@ import static android.Manifest.permission.ACCESS_COARSE_LOCATION;
 import static android.Manifest.permission.ACCESS_FINE_LOCATION;
 
 import android.content.ComponentName;
-import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
 import android.util.Log;
@@ -22,14 +21,12 @@ import androidx.core.view.ViewCompat;
 import androidx.core.view.WindowInsetsCompat;
 import app.organicmaps.downloader.DownloaderActivity;
 import app.organicmaps.intent.Factory;
-import app.organicmaps.sdk.display.DisplayManager;
 import app.organicmaps.sdk.location.LocationHelper;
 import app.organicmaps.sdk.util.Config;
 import app.organicmaps.sdk.util.LocationUtils;
 import app.organicmaps.sdk.util.concurrency.UiThread;
 import app.organicmaps.sdk.util.log.Logger;
 import app.organicmaps.util.SharingUtils;
-import app.organicmaps.util.ThemeUtils;
 import app.organicmaps.util.Utils;
 import com.google.android.material.dialog.MaterialAlertDialogBuilder;
 import java.io.IOException;

android/app/src/main/java/app/organicmaps/backup/BackupUtils.java

@@ -17,7 +17,7 @@ import androidx.annotation.NonNull;
 import androidx.documentfile.provider.DocumentFile;
 import app.organicmaps.R;
 import app.organicmaps.sdk.util.log.Logger;
-import app.organicmaps.util.UiUtils;
+
 import java.time.LocalDateTime;
 import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;

android/app/src/main/java/app/organicmaps/car/util/RoutingUtils.java

@@ -8,7 +8,6 @@ import androidx.car.app.CarContext;
 import androidx.car.app.model.CarIcon;
 import androidx.car.app.navigation.model.Destination;
 import androidx.car.app.navigation.model.Lane;
-import androidx.car.app.navigation.model.LaneDirection;
 import androidx.car.app.navigation.model.Step;
 import androidx.car.app.navigation.model.TravelEstimate;
 import androidx.car.app.navigation.model.Trip;

android/app/src/main/java/app/organicmaps/downloader/DownloaderAdapter.java

@@ -382,10 +382,7 @@ class DownloaderAdapter extends RecyclerView.Adapter<DownloaderAdapter.ViewHolde
         else
           processLongClick();
       }
-      case CountryItem.STATUS_FAILED ->
+      case CountryItem.STATUS_FAILED -> MapManagerHelper.warn3gAndRetry(mActivity, mItem.id, null);
-      {
-        MapManagerHelper.warn3gAndRetry(mActivity, mItem.id, null);
-      }
       case CountryItem.STATUS_UPDATABLE ->
         MapManagerHelper.warnOn3gUpdate(mActivity, mItem.id, () -> MapManagerHelper.startUpdate(mItem.id));
       default -> throw new IllegalArgumentException("Inappropriate item status: " + mItem.status);

android/app/src/main/java/app/organicmaps/editor/FeatureCategoryAdapter.java

@@ -66,12 +66,9 @@ public class FeatureCategoryAdapter extends RecyclerView.Adapter<RecyclerView.Vi
     case TYPE_FOOTER ->
     {
       return new FooterViewHolder(inflater.inflate(R.layout.item_feature_category_footer, parent, false),
-                                  (FooterListener) mFragment);
+              mFragment);
-    }
-    default ->
-    {
-      throw new IllegalArgumentException("Unsupported viewType: " + viewType);
     }
+    default -> throw new IllegalArgumentException("Unsupported viewType: " + viewType);
     }
   }
 

android/app/src/main/java/app/organicmaps/editor/FeatureCategoryFragment.java

@@ -4,7 +4,6 @@ import static app.organicmaps.sdk.util.Utils.getLocalizedFeatureType;
 
 import android.content.Intent;
 import android.os.Bundle;
-import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
@@ -15,7 +14,6 @@ import androidx.annotation.Nullable;
 import app.organicmaps.MwmApplication;
 import app.organicmaps.R;
 import app.organicmaps.base.BaseMwmRecyclerFragment;
-import app.organicmaps.dialog.EditTextDialogFragment;
 import app.organicmaps.sdk.Framework;
 import app.organicmaps.sdk.editor.Editor;
 import app.organicmaps.sdk.editor.OsmOAuth;

android/app/src/main/java/app/organicmaps/help/HelpFragment.java

@@ -17,7 +17,6 @@ import app.organicmaps.BuildConfig;
 import app.organicmaps.R;
 import app.organicmaps.base.BaseMwmFragment;
 import app.organicmaps.sdk.Framework;
-import app.organicmaps.sdk.util.Config;
 import app.organicmaps.sdk.util.Constants;
 import app.organicmaps.sdk.util.DateUtils;
 import app.organicmaps.util.Graphics;

android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java

@@ -38,7 +38,6 @@ import app.organicmaps.sdk.routing.RoutingController;
 import app.organicmaps.sdk.util.Config;
 import app.organicmaps.util.ThemeUtils;
 import app.organicmaps.util.UiUtils;
-import app.organicmaps.util.Utils;
 import app.organicmaps.util.WindowInsetUtils;
 import app.organicmaps.widget.menu.MyPositionButton;
 import app.organicmaps.widget.placepage.PlacePageViewModel;

android/app/src/main/java/app/organicmaps/routing/NavigationController.java

@@ -31,7 +31,6 @@ import app.organicmaps.widget.LanesView;
 import app.organicmaps.widget.SpeedLimitView;
 import app.organicmaps.widget.menu.NavMenu;
 import com.google.android.material.bottomsheet.BottomSheetBehavior;
-import com.google.android.material.imageview.ShapeableImageView;
 import com.google.android.material.textview.MaterialTextView;
 
 public class NavigationController implements TrafficManager.TrafficCallback, NavMenu.NavMenuListener

android/app/src/main/java/app/organicmaps/routing/RoutingErrorDialogFragment.java

@@ -16,7 +16,6 @@ import androidx.fragment.app.FragmentManager;
 import app.organicmaps.R;
 import app.organicmaps.downloader.MapManagerHelper;
 import app.organicmaps.sdk.downloader.CountryItem;
-import app.organicmaps.sdk.downloader.MapManager;
 import app.organicmaps.util.UiUtils;
 import com.google.android.material.textview.MaterialTextView;
 

android/app/src/main/java/app/organicmaps/search/TabAdapter.java

@@ -150,7 +150,7 @@ class TabAdapter extends FragmentPagerAdapter
 
     ViewPager.OnPageChangeListener listener = new PageChangedListener(tabs);
     mPager.addOnPageChangeListener(listener);
-    tabs.setOnTabSelectedListener(new OnTabSelectedListenerForViewPager(mPager));
+    tabs.addOnTabSelectedListener(new OnTabSelectedListenerForViewPager(mPager));
     SharedPreferences preferences = MwmApplication.prefs(mPager.getContext());
     int lastSelectedTabPosition = preferences.getInt(Config.KEY_PREF_LAST_SEARCHED_TAB, 0);
     listener.onPageSelected(lastSelectedTabPosition);

android/app/src/main/java/app/organicmaps/widget/placepage/PlacePageViewModel.java

@@ -3,10 +3,9 @@ package app.organicmaps.widget.placepage;
 import androidx.lifecycle.LiveData;
 import androidx.lifecycle.MutableLiveData;
 import androidx.lifecycle.ViewModel;
-import app.organicmaps.sdk.bookmarks.data.Bookmark;
+
-import app.organicmaps.sdk.bookmarks.data.ElevationInfo;
 import app.organicmaps.sdk.bookmarks.data.MapObject;
-import app.organicmaps.sdk.bookmarks.data.Track;
+
 import java.util.List;
 
 public class PlacePageViewModel extends ViewModel

android/sdk/src/main/java/app/organicmaps/sdk/editor/OpeningHours.java

@@ -3,7 +3,7 @@ package app.organicmaps.sdk.editor;
 import androidx.annotation.IntRange;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
-import app.organicmaps.sdk.editor.OhState;
+
 import app.organicmaps.sdk.editor.data.Timespan;
 import app.organicmaps.sdk.editor.data.Timetable;
 

android/sdk/src/main/java/app/organicmaps/sdk/maplayer/Mode.java

@@ -3,7 +3,6 @@ package app.organicmaps.sdk.maplayer;
 import android.content.Context;
 import androidx.annotation.NonNull;
 import app.organicmaps.sdk.Framework;
-import app.organicmaps.sdk.R;
 import app.organicmaps.sdk.maplayer.isolines.IsolinesManager;
 import app.organicmaps.sdk.maplayer.subway.SubwayManager;
 import app.organicmaps.sdk.maplayer.traffic.TrafficManager;

android/sdk/src/main/java/app/organicmaps/sdk/maplayer/isolines/IsolinesState.java

@@ -5,5 +5,5 @@ public enum IsolinesState
   DISABLED,
   ENABLED,
   EXPIREDDATA,
-  NODATA;
+  NODATA
 }

android/sdk/src/main/java/app/organicmaps/sdk/util/Config.java

@@ -4,7 +4,6 @@ import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.Build;
 import androidx.annotation.NonNull;
-import app.organicmaps.sdk.R;
 
 public final class Config
 {

android/sdk/src/main/java/app/organicmaps/sdk/util/log/Logger.java

@@ -131,12 +131,12 @@ public final class Logger
 
       final String threadName = "(" + Thread.currentThread().getName() + ") ";
       if (logsFolder == null || BuildConfig.DEBUG)
-        Log.println(level, tag, threadName + sb.toString());
+        Log.println(level, tag, threadName + sb);
 
       if (logsFolder != null)
       {
         sb.insert(0, String.valueOf(getLevelChar(level)) + '/' + tag + ": ");
-        LogsManager.EXECUTOR.execute(new WriteTask(logsFolder + File.separator + FILENAME, threadName + sb.toString()));
+        LogsManager.EXECUTOR.execute(new WriteTask(logsFolder + File.separator + FILENAME, threadName + sb));
       }
     }
   }