From bab74782f8f3278944483be7768ed61f63e3a8ef Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Date: Sun, 26 Oct 2025 10:20:34 +0100 Subject: [PATCH] [android] Remove title list in description list view Signed-off-by: Jean-Baptiste --- .../organicmaps/bookmarks/BookmarkListAdapter.java | 2 -- .../java/app/organicmaps/bookmarks/Holders.java | 13 ++++++------- .../main/res/layout/item_category_description.xml | 9 +-------- android/app/src/main/res/values/strings.xml | 1 + 4 files changed, 8 insertions(+), 17 deletions(-) diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListAdapter.java b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListAdapter.java index 31b49aad7..fa3c7b416 100644 --- a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListAdapter.java +++ b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListAdapter.java @@ -466,12 +466,10 @@ public class BookmarkListAdapter extends RecyclerView.Adapter onMoreButtonClicked(text, moreBtn)); moreBtn.setOnClickListener(v -> onMoreButtonClicked(text, moreBtn)); - title.setOnClickListener(v -> onMoreButtonClicked(text, moreBtn)); break; } diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/Holders.java b/android/app/src/main/java/app/organicmaps/bookmarks/Holders.java index bd9c2b3bd..725062d34 100644 --- a/android/app/src/main/java/app/organicmaps/bookmarks/Holders.java +++ b/android/app/src/main/java/app/organicmaps/bookmarks/Holders.java @@ -438,21 +438,17 @@ public class Holders static final float SPACING_MULTIPLE = 1.0f; static final float SPACING_ADD = 0.0f; @NonNull - private final MaterialTextView mTitle; - @NonNull private final MaterialTextView mDescText; DescriptionViewHolder(@NonNull View itemView, @NonNull BookmarkCategory category) { super(itemView); mDescText = itemView.findViewById(R.id.text); - mTitle = itemView.findViewById(R.id.title); } @Override void bind(@NonNull SectionPosition position, @NonNull BookmarkListAdapter.SectionsDataSource sectionsDataSource) { - mTitle.setText(sectionsDataSource.getCategory().getName()); bindDescription(sectionsDataSource.getCategory()); } @@ -462,9 +458,12 @@ public class Holders String formattedDesc = desc.replace("\n", "
"); Spanned spannedDesc = Utils.fromHtml(formattedDesc); - mDescText.setText(spannedDesc); - - UiUtils.showIf(!TextUtils.isEmpty(spannedDesc), mDescText); + if (!TextUtils.isEmpty(spannedDesc)) { + mDescText.setText(spannedDesc); + } + else { + mDescText.setText(R.string.list_description_empty); + } } } } diff --git a/android/app/src/main/res/layout/item_category_description.xml b/android/app/src/main/res/layout/item_category_description.xml index 26d032e68..d9526be20 100644 --- a/android/app/src/main/res/layout/item_category_description.xml +++ b/android/app/src/main/res/layout/item_category_description.xml @@ -6,18 +6,11 @@ android:background="?cardBackground" android:padding="@dimen/margin_base"> - - + app:layout_constraintTop_toTopOf="parent"> Invalid number Offline Maps A map needs to be downloaded to view and navigate the area.\nDownload maps for areas you want to travel. + Edit the list to add a description