drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2025-12-21 13:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

[android] Fix somes Android warnings

Browse Source 
Signed-off-by: Jean-Baptiste Charron <jeanbaptiste.charron@outlook.fr>
This commit is contained in:
Jean-Baptiste
2025-06-04 19:34:14 +02:00
committed by Harry Bond
parent 7f9b6f87c6
commit 8e6cdfeafc
20 changed files with 5 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
android/app/src/main/java/app/organicmaps/MwmActivity.java
View File

@@ -80,7 +80,6 @@ import app.organicmaps.routing.ManageRouteBottomSheet;
import app.organicmaps.routing.NavigationController;
import app.organicmaps.routing.NavigationService;
import app.organicmaps.sdk.routing.RouteMarkType;
import app.organicmaps.sdk.routing.RoutePointInfo;
import app.organicmaps.routing.RoutingBottomMenuListener;
import app.organicmaps.routing.RoutingController;
import app.organicmaps.routing.RoutingErrorDialogFragment;
@@ -2379,9 +2378,7 @@ public class MwmActivity extends BaseMwmFragmentActivity
.setTitle(R.string.track_recording_alert_title)
.setCancelable(false)
// Negative/Positive/Neutral do not have their usual meaning here.
.setNegativeButton(R.string.continue_recording, (dialog, which) -> {
mAlertDialog = null;
})
.setNegativeButton(R.string.continue_recording, (dialog, which) -> mAlertDialog = null)
.setNeutralButton(R.string.stop_without_saving, (dialog, which) -> {
stopTrackRecording();
mAlertDialog = null;

2
android/app/src/main/java/app/organicmaps/bookmarks/data/BookmarkManager.java
View File

@@ -923,7 +923,7 @@ public enum BookmarkManager
public interface BookmarksSortingListener
{
void onBookmarksSortingCompleted(@NonNull SortedBlock[] sortedBlocks, long timestamp);
default void onBookmarksSortingCancelled(long timestamp) {};
default void onBookmarksSortingCancelled(long timestamp) {}
}
public interface BookmarksSharingListener

1
android/app/src/main/java/app/organicmaps/bookmarks/data/Icon.java
View File

@@ -5,7 +5,6 @@ import android.os.Parcelable;
import androidx.annotation.DrawableRes;
import androidx.annotation.IntDef;
import androidx.annotation.NonNull;
import com.google.common.base.Objects;

4
android/app/src/main/java/app/organicmaps/bookmarks/data/MapObject.java
View File

@@ -10,16 +10,12 @@ import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.os.ParcelCompat;
import app.organicmaps.Framework;
import app.organicmaps.sdk.routing.RoutePointInfo;
import app.organicmaps.sdk.search.Popularity;
import app.organicmaps.util.Utils;
import app.organicmaps.widget.placepage.PlacePageData;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

5
android/app/src/main/java/app/organicmaps/downloader/DownloaderAdapter.java
View File

@@ -380,10 +380,7 @@ class DownloaderAdapter extends RecyclerView.Adapter<DownloaderAdapter.ViewHolde
else
processLongClick();
}
case CountryItem.STATUS_FAILED ->
{
MapManager.warn3gAndRetry(mActivity, mItem.id, null);
}
case CountryItem.STATUS_FAILED -> MapManager.warn3gAndRetry(mActivity, mItem.id, null);
case CountryItem.STATUS_UPDATABLE ->
MapManager.warnOn3gUpdate(mActivity, mItem.id, () -> MapManager.startUpdate(mItem.id));
default -> throw new IllegalArgumentException("Inappropriate item status: " + mItem.status);

2
android/app/src/main/java/app/organicmaps/editor/EditorHostFragment.java
View File

@@ -1,6 +1,5 @@
package app.organicmaps.editor;
import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
@@ -25,7 +24,6 @@ import app.organicmaps.editor.data.LocalizedName;
import app.organicmaps.editor.data.LocalizedStreet;
import app.organicmaps.editor.data.NamesDataSource;
import app.organicmaps.editor.data.PhoneFragment;
import app.organicmaps.util.ConnectionState;
import app.organicmaps.util.UiUtils;
import app.organicmaps.util.Utils;
import app.organicmaps.util.WindowInsetUtils.PaddingInsetsListener;

4
android/app/src/main/java/app/organicmaps/editor/FeatureCategoryAdapter.java
View File

@@ -56,9 +56,7 @@ public class FeatureCategoryAdapter extends RecyclerView.Adapter<RecyclerView.Vi
case TYPE_FOOTER -> {
return new FooterViewHolder(LayoutInflater.from(parent.getContext()).inflate(R.layout.item_feature_category_footer, parent, false));
}
default -> {
throw new IllegalArgumentException("Unsupported");
}
default -> throw new IllegalArgumentException("Unsupported");
}
}

3
android/app/src/main/java/app/organicmaps/editor/FeatureCategoryFragment.java
View File

@@ -1,16 +1,13 @@
package app.organicmaps.editor;
import android.os.Bundle;
import android.text.method.LinkMovementMethod;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.TextView;
import androidx.annotation.CallSuper;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.widget.NestedScrollView;
import app.organicmaps.R;
import app.organicmaps.base.BaseMwmRecyclerFragment;

2
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
View File

@@ -9,12 +9,10 @@ import android.view.ViewGroup;
import android.widget.Button;
import android.widget.ProgressBar;
import android.widget.ScrollView;
import android.widget.TextView;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.view.ViewCompat;
import app.organicmaps.BuildConfig;
import app.organicmaps.Framework;
import app.organicmaps.R;
import app.organicmaps.base.BaseMwmToolbarFragment;

2
android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
View File

@@ -10,8 +10,6 @@ import androidx.annotation.Size;
import androidx.annotation.WorkerThread;
import androidx.fragment.app.FragmentManager;
import java.util.Map;
import app.organicmaps.MwmApplication;
import app.organicmaps.util.NetworkPolicy;

1
android/app/src/main/java/app/organicmaps/editor/SelfServiceAdapter.java
View File

@@ -11,7 +11,6 @@ import androidx.annotation.NonNull;
import androidx.recyclerview.widget.RecyclerView;
import app.organicmaps.R;
import app.organicmaps.util.UiUtils;
import app.organicmaps.util.Utils;
public class SelfServiceAdapter extends RecyclerView.Adapter<SelfServiceAdapter.ViewHolder>

1
android/app/src/main/java/app/organicmaps/editor/SelfServiceFragment.java
View File

@@ -11,7 +11,6 @@ import androidx.annotation.Nullable;
import app.organicmaps.base.BaseMwmRecyclerFragment;
import app.organicmaps.bookmarks.data.Metadata;
import app.organicmaps.editor.data.LocalizedStreet;
public class SelfServiceFragment extends BaseMwmRecyclerFragment<SelfServiceAdapter>
{

2
android/app/src/main/java/app/organicmaps/editor/StreetFragment.java
View File

@@ -15,8 +15,6 @@ import app.organicmaps.base.BaseMwmRecyclerFragment;
import app.organicmaps.dialog.EditTextDialogFragment;
import app.organicmaps.editor.data.LocalizedStreet;
import java.util.Optional;
public class StreetFragment extends BaseMwmRecyclerFragment<StreetAdapter>
{
private LocalizedStreet mSelectedString;

1
android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java
View File

@@ -32,7 +32,6 @@ import app.organicmaps.maplayer.subway.SubwayManager;
import app.organicmaps.maplayer.traffic.TrafficManager;
import app.organicmaps.routing.RoutingController;
import app.organicmaps.util.Config;
import app.organicmaps.util.ThemeUtils;
import app.organicmaps.util.UiUtils;
import app.organicmaps.util.WindowInsetUtils;
import app.organicmaps.widget.menu.MyPositionButton;

1
android/app/src/main/java/app/organicmaps/routing/ManageRouteAdapter.java
View File

@@ -19,7 +19,6 @@ import app.organicmaps.R;
import app.organicmaps.bookmarks.data.MapObject;
import app.organicmaps.sdk.routing.RouteMarkData;
import app.organicmaps.sdk.routing.RouteMarkType;
import app.organicmaps.sdk.routing.RoutePointInfo;
import app.organicmaps.util.StringUtils;
import app.organicmaps.util.UiUtils;

1
android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java
View File

@@ -34,7 +34,6 @@ import app.organicmaps.bookmarks.data.DistanceAndAzimut;
import app.organicmaps.location.LocationHelper;
import app.organicmaps.sdk.routing.RouteMarkData;
import app.organicmaps.sdk.routing.RouteMarkType;
import app.organicmaps.sdk.routing.RoutePointInfo;
import app.organicmaps.sdk.routing.RoutingInfo;
import app.organicmaps.sdk.routing.TransitRouteInfo;
import app.organicmaps.sdk.routing.TransitStepInfo;

1
android/app/src/main/java/app/organicmaps/search/SearchCategoriesFragment.java
View File

@@ -4,7 +4,6 @@ import android.os.Bundle;
import android.view.View;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import app.organicmaps.R;
import app.organicmaps.base.BaseMwmRecyclerFragment;

4
android/app/src/main/java/app/organicmaps/search/SearchFragment.java
View File

@@ -176,9 +176,7 @@ public class SearchFragment extends BaseMwmFragment
private boolean mInitialSearchOnMap = false;
private final ActivityResultLauncher<Intent> startVoiceRecognitionForResult = registerForActivityResult(new ActivityResultContracts.StartActivityForResult(), activityResult ->
{
mToolbarController.onVoiceRecognitionResult(activityResult);
});
mToolbarController.onVoiceRecognitionResult(activityResult));
private final LocationListener mLocationListener = new LocationListener()
{

2
android/app/src/main/java/app/organicmaps/settings/BaseXmlSettingsFragment.java
View File

@@ -15,9 +15,7 @@ import androidx.recyclerview.widget.RecyclerView;
import app.organicmaps.R;
import app.organicmaps.util.ThemeUtils;
import app.organicmaps.util.UiUtils;
import app.organicmaps.util.Utils;
import app.organicmaps.util.WindowInsetUtils;
import app.organicmaps.util.WindowInsetUtils.ScrollableContentInsetsListener;
abstract class BaseXmlSettingsFragment extends PreferenceFragmentCompat

1
android/app/src/main/java/app/organicmaps/util/UiUtils.java
View File

@@ -19,7 +19,6 @@ import android.view.WindowManager;
import android.widget.Button;
import android.widget.TextView;
import androidx.activity.result.ActivityResult;
import androidx.activity.result.ActivityResultLauncher;
import androidx.annotation.AnyRes;
import androidx.annotation.AttrRes;