drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2025-12-19 21:13:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed failing is_finite tests on the latest clang

Browse Source 
Signed-off-by: Alexander Borsuk <me@alex.bio>
This commit is contained in:
Alexander Borsuk
2025-06-20 04:11:56 +02:00
committed by Konstantin Pastbin
parent 8fe788c98d
commit 82133c5743
11 changed files with 97 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
base/string_utils.cpp
View File

@@ -1,6 +1,7 @@
#include "base/string_utils.hpp"
#include "base/assert.hpp"
#include "base/math.hpp"
#include "base/stl_helpers.hpp"
#include <algorithm>
@@ -10,7 +11,6 @@
#include <iterator>
#include <boost/algorithm/string/trim.hpp>
#include <boost/math/special_functions/fpclassify.hpp>
#include <fast_double_parser.h>
namespace strings
@@ -34,27 +34,22 @@ double RealConverter<double>(char const * start, char ** stop)
return std::strtod(start, stop);
}
template <typename T>
bool IsFinite(T t)
{
return boost::math::isfinite(t);
}
template <typename T>
bool ToReal(char const * start, T & result)
{
// Try faster implementation first.
double d;
// TODO(AB): replace with more robust dependency that doesn't use std::is_finite in the implementation.
char const * endptr = fast_double_parser::parse_number(start, &d);
if (endptr == nullptr)
{
// Fallback to our implementation, it supports numbers like "1."
char * stop;
result = RealConverter<T>(start, &stop);
if (*stop == 0 && start != stop && IsFinite(result))
if (*stop == 0 && start != stop && math::is_finite(result))
return true;
}
else if (*endptr == 0 && IsFinite(d))
else if (*endptr == 0 && math::is_finite(d))
{
result = static_cast<T>(d);
return true;
@@ -116,11 +111,6 @@ bool to_double(char const * start, double & d)
return ToReal(start, d);
}
bool is_finite(double d)
{
return IsFinite(d);
}
UniString MakeLowerCase(UniString s)
{
MakeLowerCaseInplace(s);