drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2025-12-19 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

review fixes

Browse Source 
Signed-off-by: map-per <map-per@gmx.de>
This commit is contained in:
map-per
2025-12-15 21:11:22 +01:00
parent 02ac1d8977
commit 8007c0df53
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libs/editor/feature_type_to_osm.cpp
View File

@@ -40,7 +40,7 @@ void TypeToOSMTranslator::LoadFromStream(std::istream & s)
line.back() != ';') line.back() != ';')
continue; continue;
std::vector<std::string_view> rowTokens = strings::Tokenize(line, ";"); std::vector<std::string_view> const rowTokens = strings::Tokenize(line, ";");
if (rowTokens.size() < 2) if (rowTokens.size() < 2)
{ {
ASSERT(false, ("Invalid feature type definition:", line)); ASSERT(false, ("Invalid feature type definition:", line));
@@ -48,8 +48,8 @@ void TypeToOSMTranslator::LoadFromStream(std::istream & s)
} }
// Get internal feature type // Get internal feature type
std::vector<std::string_view> featureTypeTokens = strings::Tokenize(rowTokens[0], "|"); std::vector<std::string_view> const featureTypeTokens = strings::Tokenize(rowTokens[0], "|");
uint32_t type = classif().GetTypeByPathSafe(featureTypeTokens); uint32_t const type = classif().GetTypeByPathSafe(featureTypeTokens);
ASSERT(type != IndexAndTypeMapping::INVALID_TYPE, ("Feature with invalid type:", line)); ASSERT(type != IndexAndTypeMapping::INVALID_TYPE, ("Feature with invalid type:", line));
if (rowTokens.size() == 2) if (rowTokens.size() == 2)
@@ -77,10 +77,10 @@ void TypeToOSMTranslator::LoadFromStream(std::istream & s)
else else
{ {
// OSM tags are listed in the feature type entry // OSM tags are listed in the feature type entry
std::vector<std::string_view> osmTagTokens = strings::Tokenize(rowTokens[1], ","); std::vector<std::string_view> const osmTagTokens = strings::Tokenize(rowTokens[1], ",");
// First entry is the best practice way to tag a feature // First entry is the best practice way to tag a feature
std::string_view osmTagList = osmTagTokens[0]; std::string_view const osmTagList = osmTagTokens[0];
// Process OSM tag list (e.g. "[tourism=information][information=office]") // Process OSM tag list (e.g. "[tourism=information][information=office]")
std::vector<OSMTag> osmTags; std::vector<OSMTag> osmTags;

2
libs/editor/xml_feature.cpp
View File

@@ -650,7 +650,7 @@ void XMLFeature::SetOSMTagsForType(uint32_t type)
std::vector<OSMTag> const & osmTags = GetOSMTranslator().OsmTagsFromType(type); std::vector<OSMTag> const & osmTags = GetOSMTranslator().OsmTagsFromType(type);
for(auto const & osmTag : osmTags) for (auto const & osmTag : osmTags)
SetTagValue(osmTag.key, osmTag.value); SetTagValue(osmTag.key, osmTag.value);
} }