diff --git a/traffxml/traff_decoder.cpp b/traffxml/traff_decoder.cpp index 2db984d31..10fe48756 100644 --- a/traffxml/traff_decoder.cpp +++ b/traffxml/traff_decoder.cpp @@ -29,6 +29,8 @@ namespace traffxml { +// Only needed for OpenlrTraffDecoder, see below +#if 0 // Number of worker threads for the OpenLR decoder /* * TODO how to determine the best number of worker threads? @@ -37,6 +39,7 @@ namespace traffxml * Otherwise there is little to be gained, as we decode messages one at a time. */ auto constexpr kNumDecoderThreads = 1; +#endif // Timeout for the router in seconds, used by RoutingTraffDecoder // TODO set to a sensible value diff --git a/traffxml/traff_decoder.hpp b/traffxml/traff_decoder.hpp index 6189aea8b..5cfe044a9 100644 --- a/traffxml/traff_decoder.hpp +++ b/traffxml/traff_decoder.hpp @@ -41,6 +41,8 @@ public: const CountryParentNameGetterFn & countryParentNameGetter, std::map & messageCache); + virtual ~TraffDecoder() {} + /** * @brief Decodes a single message to its segments and their speed groups. * diff --git a/traffxml/traff_model_xml.cpp b/traffxml/traff_model_xml.cpp index 50e022064..bc31b346b 100644 --- a/traffxml/traff_model_xml.cpp +++ b/traffxml/traff_model_xml.cpp @@ -826,8 +826,9 @@ bool SegmentFromXml(pugi::xml_node const & node, std::map & coloring) { uint32_t fid; - uint16_t idx; - uint8_t dir; + // initialize to get rid of compiler warnings (which are false alerts) + uint16_t idx = 0; + uint8_t dir = 0; if (IntegerFromXml(node.attribute("fid"), fid) && IntegerFromXml(node.attribute("idx"), idx) && IntegerFromXml(node.attribute("dir"), dir)) diff --git a/traffxml/traff_source.hpp b/traffxml/traff_source.hpp index 27aa836d3..b93d15a86 100644 --- a/traffxml/traff_source.hpp +++ b/traffxml/traff_source.hpp @@ -26,6 +26,8 @@ class TraffSource; class TraffSourceManager { public: + virtual ~TraffSourceManager() {} + /** * @brief Retrieves all currently active MWMs. *