drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2025-12-20 13:23:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[linux] Fix zero file creation (birth) time

Browse Source 
Observed in Ubuntu 24 via Orb on arm-based Mac

Signed-off-by: Alexander Borsuk <me@alex.bio>
This commit is contained in:
Alexander Borsuk
2025-07-26 20:10:04 +02:00
committed by Konstantin Pastbin
parent fbaa59ce3b
commit 674abcf02e
5 changed files with 56 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
libs/platform/platform_win.cpp
View File

@@ -220,7 +220,10 @@ time_t GetFileTime(std::string const & path, FileTimeType fileTimeType)
{
HANDLE hFile = CreateFileA(path.c_str(), GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL);
if (hFile == INVALID_HANDLE_VALUE)
return 0;
{
LOG(LERROR, ("GetFileTime CreateFileA failed for", path, "with error", strerror(errno)));
return 0; // TODO(AB): Refactor to return std::optional<time_t>.
}
SCOPE_GUARD(autoClose, bind(&CloseHandle, hFile));
@@ -234,8 +237,11 @@ time_t GetFileTime(std::string const & path, FileTimeType fileTimeType)
case FileTimeType::Modification: ftLastWrite = &ft; break;
}
if (!GetFileTime(hFile, ftCreate, nullptr, ftLastWrite))
return 0;
if (!::GetFileTime(hFile, ftCreate, nullptr, ftLastWrite))
{
LOG(LERROR, ("GetFileTime ::GetFileTime failed for", path, "with error", strerror(errno)));
return 0; // TODO(AB): Refactor to return std::optional<time_t>.
}
ULARGE_INTEGER ull;
ull.LowPart = ft.dwLowDateTime;
@@ -247,12 +253,14 @@ time_t GetFileTime(std::string const & path, FileTimeType fileTimeType)
// static
time_t Platform::GetFileCreationTime(std::string const & path)
{
// TODO(AB): Refactor to return std::optional<time_t>.
return GetFileTime(path, FileTimeType::Creation);
}
// static
time_t Platform::GetFileModificationTime(std::string const & path)
{
// TODO(AB): Refactor to return std::optional<time_t>.
return GetFileTime(path, FileTimeType::Modification);
}