drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2026-01-07 13:03:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ios] make MWMSearchFrameworkHelper methods class instead of instance

Browse Source 
Because there is no any stored property in this manager so there is no reason to create it's instance.

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
This commit is contained in:
Kiryl Kaveryn
2025-05-26 17:50:18 +04:00
committed by Konstantin Pastbin
parent 8a331c4c67
commit 648fb55130
5 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
iphone/Maps/UI/Search/Tabs/CategoriesTab/SearchCategoriesViewController.swift
View File

@@ -7,7 +7,7 @@ final class SearchCategoriesViewController: MWMTableViewController {
private weak var delegate: SearchCategoriesViewControllerDelegate?
private let categories: [String]
init(frameworkHelper: MWMSearchFrameworkHelper, delegate: SearchCategoriesViewControllerDelegate?) {
init(frameworkHelper: MWMSearchFrameworkHelper.Type, delegate: SearchCategoriesViewControllerDelegate?) {
self.delegate = delegate
categories = frameworkHelper.searchCategories()
super.init(nibName: nil, bundle: nil)

4
iphone/Maps/UI/Search/Tabs/HistoryTab/SearchHistoryViewController.swift
View File

@@ -6,14 +6,14 @@ protocol SearchHistoryViewControllerDelegate: SearchOnMapScrollViewDelegate {
final class SearchHistoryViewController: MWMViewController {
private weak var delegate: SearchHistoryViewControllerDelegate?
private var lastQueries: [String] = []
private let frameworkHelper: MWMSearchFrameworkHelper
private let frameworkHelper: MWMSearchFrameworkHelper.Type
private let emptyHistoryView = PlaceholderView(title: L("search_history_title"),
subtitle: L("search_history_text"))
private let tableView = UITableView()
// MARK: - Init
init(frameworkHelper: MWMSearchFrameworkHelper, delegate: SearchHistoryViewControllerDelegate?) {
init(frameworkHelper: MWMSearchFrameworkHelper.Type, delegate: SearchHistoryViewControllerDelegate?) {
self.delegate = delegate
self.frameworkHelper = frameworkHelper
super.init(nibName: nil, bundle: nil)

6
iphone/Maps/UI/Search/Tabs/SearchTabViewController.swift
View File

@@ -13,10 +13,8 @@ final class SearchTabViewController: TabViewController {
private static let selectedIndexKey = "SearchTabViewController_selectedIndexKey"
@objc weak var delegate: SearchTabViewControllerDelegate?
private lazy var frameworkHelper: MWMSearchFrameworkHelper = {
return MWMSearchFrameworkHelper()
}()
private var frameworkHelper = MWMSearchFrameworkHelper.self
private var activeTab: SearchActiveTab = SearchActiveTab.init(rawValue:
UserDefaults.standard.integer(forKey: SearchTabViewController.selectedIndexKey)) ?? .categories {
didSet {