drifty/comaps
1
0
Fork 0
mirror of https://codeberg.org/comaps/comaps synced 2025-12-19 13:03:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ios] Pass specific phone to call instead of entire POI information

Browse Source 
For now, it doesn't change anything because there's still at most one
phone, but this will help with multiple phone numbers because we'll need
to know which phone number the user has picked.

Signed-off-by: Eugene Nikolsky <omaps@egeek.me>
This commit is contained in:
Eugene Nikolsky
2025-04-02 20:10:58 +03:00
committed by Konstantin Pastbin
parent 9be9f17df9
commit 56c4918e93
4 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
iphone/Maps/UI/PlacePage/PlacePageInteractor.swift
View File

@@ -66,7 +66,7 @@ extension PlacePageInteractor: PlacePageInfoViewControllerDelegate {
} }
func didPressCall() { func didPressCall() {
MWMPlacePageManagerHelper.call(placePageData) MWMPlacePageManagerHelper.call(placePageData.infoData?.phone)
} }
func didPressWebsite() { func didPressWebsite() {
@@ -188,7 +188,7 @@ extension PlacePageInteractor: ActionBarViewControllerDelegate {
MWMPlacePageManagerHelper.addBookmark(placePageData) MWMPlacePageManagerHelper.addBookmark(placePageData)
} }
case .call: case .call:
MWMPlacePageManagerHelper.call(placePageData) MWMPlacePageManagerHelper.call(placePageData.infoData?.phone)
case .download: case .download:
guard let mapNodeAttributes = placePageData.mapNodeAttributes else { guard let mapNodeAttributes = placePageData.mapNodeAttributes else {
fatalError("Download button can't be displayed if mapNodeAttributes is empty") fatalError("Download button can't be displayed if mapNodeAttributes is empty")

4
iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManager.mm
View File

@@ -194,8 +194,8 @@ using namespace storage;
f.GetBookmarkManager().GetEditSession().DeleteTrack(data.trackData.trackId); f.GetBookmarkManager().GetEditSession().DeleteTrack(data.trackData.trackId);
} }
- (void)call:(PlacePageData *)data { - (void)call:(PlacePagePhone *)phone {
NSURL * _Nullable phoneURL = data.infoData.phone.url; NSURL * _Nullable phoneURL = phone.url;
if (phoneURL && [UIApplication.sharedApplication canOpenURL:phoneURL]) { if (phoneURL && [UIApplication.sharedApplication canOpenURL:phoneURL]) {
[UIApplication.sharedApplication openURL:phoneURL options:@{} completionHandler:nil]; [UIApplication.sharedApplication openURL:phoneURL options:@{} completionHandler:nil];
} }

3
iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManagerHelper.h
View File

@@ -1,4 +1,5 @@
@class PlacePageData; @class PlacePageData;
@class PlacePagePhone;
@class ElevationProfileData; @class ElevationProfileData;
@interface MWMPlacePageManagerHelper : NSObject @interface MWMPlacePageManagerHelper : NSObject
@@ -17,7 +18,7 @@
+ (void)openTwitter:(PlacePageData *)data; + (void)openTwitter:(PlacePageData *)data;
+ (void)openVk:(PlacePageData *)data; + (void)openVk:(PlacePageData *)data;
+ (void)openLine:(PlacePageData *)data; + (void)openLine:(PlacePageData *)data;
+ (void)call:(PlacePageData *)data; + (void)call:(PlacePagePhone *)phone;
+ (void)showAllFacilities:(PlacePageData *)data; + (void)showAllFacilities:(PlacePageData *)data;
+ (void)showPlaceDescription:(NSString *)htmlString; + (void)showPlaceDescription:(NSString *)htmlString;
+ (void)openMoreUrl:(PlacePageData *)data; + (void)openMoreUrl:(PlacePageData *)data;

6
iphone/Maps/UI/PlacePage/PlacePageManager/MWMPlacePageManagerHelper.mm
View File

@@ -24,7 +24,7 @@
- (void)openTwitter:(PlacePageData *)data; - (void)openTwitter:(PlacePageData *)data;
- (void)openVk:(PlacePageData *)data; - (void)openVk:(PlacePageData *)data;
- (void)openLine:(PlacePageData *)data; - (void)openLine:(PlacePageData *)data;
- (void)call:(PlacePageData *)data; - (void)call:(PlacePagePhone *)phone;
- (void)showAllFacilities:(PlacePageData *)data; - (void)showAllFacilities:(PlacePageData *)data;
- (void)showPlaceDescription:(NSString *)htmlString; - (void)showPlaceDescription:(NSString *)htmlString;
- (void)openMoreUrl:(PlacePageData *)data; - (void)openMoreUrl:(PlacePageData *)data;
@@ -109,8 +109,8 @@
[[MWMMapViewControlsManager manager].placePageManager openLine:data]; [[MWMMapViewControlsManager manager].placePageManager openLine:data];
} }
+ (void)call:(PlacePageData *)data { + (void)call:(PlacePagePhone *)phone {
[[MWMMapViewControlsManager manager].placePageManager call:data]; [[MWMMapViewControlsManager manager].placePageManager call:phone];
} }
+ (void)showAllFacilities:(PlacePageData *)data { + (void)showAllFacilities:(PlacePageData *)data {