From 2f75d3c5a821aecfec865f8a89142fea12704abf Mon Sep 17 00:00:00 2001 From: vrajs Date: Mon, 26 May 2025 11:15:10 +0530 Subject: [PATCH] Fix unintended coupling of 3D settings in Settings page session (#10581) Signed-off-by: vrajs --- .../app/organicmaps/settings/SettingsPrefsFragment.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java index 78947cc5d..f7afaf1b6 100644 --- a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java +++ b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java @@ -317,7 +317,9 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La disableOrEnable3DBuildingsForPowerMode(powerManagementValue); pref.setOnPreferenceChangeListener((preference, newValue) -> { - Framework.nativeSet3dMode(_3d.enabled, (Boolean)newValue); + Framework.Params3dMode current = new Framework.Params3dMode(); + Framework.nativeGet3dMode(current); + Framework.nativeSet3dMode(current.enabled, (Boolean)newValue); return true; }); } @@ -356,7 +358,9 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La pref.setChecked(_3d.enabled); pref.setOnPreferenceChangeListener((preference, newValue) -> { - Framework.nativeSet3dMode((Boolean) newValue, _3d.buildings); + Framework.Params3dMode current = new Framework.Params3dMode(); + Framework.nativeGet3dMode(current); + Framework.nativeSet3dMode((Boolean) newValue, current.buildings); return true; }); }