fix: don't return reference to object that goes out of scope

Signed-off-by: map-per <map-per@gmx.de>

libs/editor/feature_type_to_osm.cpp

@@ -152,7 +152,7 @@ std::vector<OSMTag> const & TypeToOSMTranslator::OsmTagsFromType(uint32_t type)
   if (it == m_storage.end())
   {
     ASSERT(false, ("OSM tags for type", type, "could not be found"));
-    return {};
+    return kEmptyResult;
   }
 
   return it->second;

libs/editor/feature_type_to_osm.hpp

@@ -16,6 +16,8 @@ struct OSMTag
 class TypeToOSMTranslator
 {
 public:
+  std::vector<OSMTag> static constexpr kEmptyResult = {};
+
   TypeToOSMTranslator() : TypeToOSMTranslator(true) {}
   explicit TypeToOSMTranslator(bool initialize);